fwahlqvist / simile-widgets

Automatically exported from code.google.com/p/simile-widgets
0 stars 0 forks source link

TIMELINE: When no event title, displays as "undefined" instead of no event title #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. populate events without a title

What is the expected output? What do you see instead?
In 1.2 titles are not shown if a title is not specified.  Events without
titles are now labeled as "undefined".  I believe that revision 1411 -
"added supported for 'hoverText' - title pop-ups on Exhibit-based
timelines" removed that check and now the title is set even if null.

I would prefer to either not have to specify event titles and/or have the
code implement showEventTitles/showEventText (true|false) as a param, so I
could control the behavior at the band level.  

I noticed the introduction of overview-painter.  That might be more
applicable for my specific use case, I'm investigating, but most
existing/casual users are going to be surprised if "undefined" starts
showing up on their timelines.

What version of the product are you using? On what operating system?
head, XP

Please provide any additional information below.

here's the lines that were removed from multiple locations within
original-painter.js 
    if(evt._title != null)
        iconDiv.title = evt._title;

Original issue reported on code.google.com by rdq...@gmail.com on 22 Sep 2008 at 9:02

GoogleCodeExporter commented 9 years ago
Confirmed. I'm building a new file in the examples directory to test this and 
other 
attribute situations.
Not only does the label show as "undefined," clicking on the tape causes a js 
error.

Original comment by larryklu...@gmail.com on 24 Sep 2008 at 2:38

GoogleCodeExporter commented 9 years ago
Added TIMELINE prefix 

Original comment by larryklu...@gmail.com on 24 Sep 2008 at 2:39

GoogleCodeExporter commented 9 years ago
Added test: .../src/webapp/examples/test_example/test.html

Fixed in rev 1598. Will be in release 2.3.0

Original comment by larryklu...@gmail.com on 24 Sep 2008 at 3:41