fwcd / kotlin-debug-adapter

Kotlin/JVM debugging for any editor/IDE using the Debug Adapter Protocol
MIT License
110 stars 19 forks source link

[WIP]feat: #39 support cwd anv env variables (using org.eclipse.jdt.debug package) #43

Closed thunderz99 closed 3 years ago

thunderz99 commented 3 years ago

An enhance for #39

Done

Doing

    implementation files('lib/org.eclipse.jdt.debug-3.15.100.jdi.jar')
    implementation files('lib/org.eclipse.jdt.debug-3.15.100.jdimodel.jar')
fwcd commented 3 years ago

Sorry for being pedantic, but I think it would be ideal if we wrote the entire implementation ourselves. EPL ist still not as permissive as MIT.

Inheriting the Sun launcher is fine (it wouldn't introduce a new dependency) as long as we write the overridden methods completely ourselves and possibly call super where needed.

thunderz99 commented 3 years ago

I think your advice is indeed and acceptable. I'll have a try :) I'll open a new pullreq when it is ready!