Closed thunderz99 closed 3 years ago
Sorry for being pedantic, but I think it would be ideal if we wrote the entire implementation ourselves. EPL ist still not as permissive as MIT.
Inheriting the Sun launcher is fine (it wouldn't introduce a new dependency) as long as we write the overridden methods completely ourselves and possibly call super
where needed.
I think your advice is indeed and acceptable. I'll have a try :) I'll open a new pullreq when it is ready!
An enhance for #39
Done
Doing