search

fwcd / kotlin-debug-adapter

Kotlin/JVM debugging for any editor/IDE using the Debug Adapter Protocol
MIT License
110 stars 19 forks source link

Use Kotlin DSL for gradle scripts #81

Closed themkat closed 5 months ago

themkat commented 5 months ago

The sharing of code from the shared module in kotlin-language-server started failing roughly at the time we set up Kotlin DSL there. (issue: #74). This PR makes it possible to use the latest shared module again.

Probably not perfect, but seems to create the necessary artifacts (i.e, zip file and executables).

About the inclusion of the exposed dependencies: If we don't add this, while still using newest kotlin-language-server:shared, we get the following error:

e: file:///Users/marie/Programming/Kotlin/kotlin-debug-adapter/adapter/src/main/kotlin/org/javacs/ktda/classpath/DebugClassPathResolver.kt:10:2 Cannot access class 'org.jetbrains.exposed.sql.Database'. Check your module classpath for missing or conflicting dependencies

Adding the dependencies fixes the issue. We should find a way to avoid adding them here, as the versions might deviate between this project and kotlin-language-server. It seems like the shared module don't read the versions from its platform module when importing it like we do in this project. We might start by looking into that.

themkat commented 5 months ago

I say we merge this now. Then people can try building themselves and maybe create PRs with solutions to what I wrote in the description 🙂

Closes #74. (hopefully)