themkat
commented
1 year ago It seems like the only failing tests has to do with resolving main class. The only issue then would be that you could not use the run/debug code lenses in VSCode and Emacs. The issue must therefore have been there for a while as this code has not been touched for almost a year. I was afraid the issue was bigger based upon the issue linked above. My guess is that almost no one uses this main resolve functionality anyway... (sadly, as it is awesome!).
Will see if I can make the test fix code a bit better tomorrow.
Can't reproduce the issue described in https://github.com/fwcd/kotlin-language-server/issues/430#issuecomment-1445192911 though
Why? According to #430 , it seems like there are some caveats for Windows with the language server. I suggest we run the pipeline for both Windows and Ubuntu to combat this. Then we can verify that we don't break anything for Windows (e.g, paths in the shared module and similar). I know that a lot of us uses Linux and Mac OS X instead, and may therefore not have access to Windows machines (I most certainly don't), so having it in the pipeline might help.
The idea behind this PR is also to fix any errors that might happen.
EDIT: Also added Mac OS X. Building on all major platforms will provide confidence for our users that our language server does indeed build on all major systems. We have had some issues reported with build issues on local machines, so having it in our pipeline can provide some confidence that it actually works.