search

fwcd / kotlin-language-server

Kotlin code completion, diagnostics and more for any editor/IDE using the Language Server Protocol
MIT License
1.62k stars 203 forks source link

Exclude test resource workspaces in detekt analysis #513

Closed themkat closed 11 months ago

themkat commented 11 months ago

If you take a look at builds in for example #498, you will notice that the test workspaces (e.g, server/src/test/resources/inlayhints are affected by detekt scans. I don't think we need to hold this code to the same standard as the main codebase. Sometimes we have minor errors and similar to check that the language server behaves correctly. Detekt will pick up on this and cause issues in the builds. One could off course put this into the baseline, but I think that is a waste of effort. Others might suggest removing it... Instead I suggest we exclude these test workspaces, and keep all the awesome benefits of Detekt 🙂

Hopefully you agree @fwcd 🙂

themkat commented 11 months ago

I think we'll merge this as it is a small change, and it is quite useful to not get "waste of time" warnings in PR builds 🙂