Fix maven repository discovery

fwcd / kotlin-language-server

Kotlin code completion, diagnostics and more for any editor/IDE using the Language Server Protocol

MIT License

1.62k stars 203 forks source link

Fix maven repository discovery #518

Closed calamont closed 10 months ago

calamont commented 11 months ago

Related to #430

Fixes the Maven repository discovery by checking if the candidate paths have a /repository directory. An exception is thrown if no valid repository paths are found. The order of discovery is maintained as before:

$MAVEN_REPOSITORY
$MAVEN_HOME
$M2_HOME
$HOME/.m2

calamont commented 10 months ago

Thanks for the reviews @themkat and @fwcd 🙂 How do you want the git history to look for this project? I can squash the new commits for the PR locally and force push a single commit to merge if you want.

themkat commented 10 months ago

Thanks for the reviews @themkat and @fwcd 🙂 How do you want the git history to look for this project? I can squash the new commits for the PR locally and force push a single commit to merge if you want.

No strong opinions from me 🙂 I squash PRs anyway when merging.

calamont commented 10 months ago

Ok cool. I'll let you guys squash when merging then 👍

themkat commented 10 months ago

All PR comments seems to be resolved, so merging. Thank you @calamont ! 😄