fwcd / kotlin-language-server

Kotlin code completion, diagnostics and more for any editor/IDE using the Language Server Protocol
MIT License
1.58k stars 202 forks source link

Improve URI Parsing #582

Open vladaviedov opened 3 weeks ago

vladaviedov commented 3 weeks ago

Go to Definition throws an exception when a JAR contains a plus sign in its name (as described in #326). parseURI calls URLDecoder.decode on its input, but if the input is not encoded, it converts the plus to a space.

I tried to remove the decoding and properly encode the file path for later usage, which seems to be working for me in both neovim and vscode, but I have no idea how to test the "invalid percent encoding for colons".