search

fwcd / tree-sitter-kotlin

Kotlin grammar for Tree-sitter
https://fwcd.github.io/tree-sitter-kotlin
MIT License
126 stars 52 forks source link

Add null_literal node. #141

Closed wolfmanstout closed 2 months ago

wolfmanstout commented 2 months ago

Fixes #140

afroozeh commented 2 months ago

Is this a copy of my PR? https://github.com/fwcd/tree-sitter-kotlin/pull/139

wolfmanstout commented 2 months ago

Is this a copy of my PR? https://github.com/fwcd/tree-sitter-kotlin/pull/139

Wow, no, that's an extraordinary coincidence. I did a search for outstanding issues but not PRs so I didn't see this. I'm happy to close this one although I'd suggest you link yours to the bug I filed and you can simplify the grammar change slightly: there's no need to wrap a single node "null" in a seq call.

wolfmanstout commented 2 months ago

Is this a copy of my PR? https://github.com/fwcd/tree-sitter-kotlin/pull/139

Also I had to fix highlights.scm, make sure your tests fully pass. I think it was just a subtle message at the bottom of the test log.

afroozeh commented 2 months ago

@wolfmanstout thanks for the clarification. I'll update my PR with the changes you mentioned. btw, it doesn't matter which one gets merged, I was just surprised that it was opened. My goal is for these changes to get in asap :-)

wolfmanstout commented 2 months ago

Duplicate of #139