There are some duplicate account IDs in the file due merges, mergers etc. I've found it useful to associate only a single vendor with each account ID as I nearly always want to map an account ID to a vendor rather than vice-versa. I wanted to submit a PR in case these changes would be helpful for anyone else.
I've tried to break this change down into atomic commits that can be easily verified. The summary is:
Replace comments with source: properties where these are clearly sources
Remove duplicate copy of "Cloudability"
Remove "Cloud Applicatoin Manager" which duplicates CenturyLinkCloud
Merge "Cloudtrail" into "CloudTrail" and eliminate duplicates
Remove "Cloudyn" which duplicates "Azure Billing Management"
Remove "Nessus AWS Connector" which duplicates "Tenable"
Remove "Dome9 Arc" which duplicates "Checkpoint Cloudguard"
Merge "FortiCASB" and "FortiCWP" under a new "Fortinet"
Add a script and github action to validate that no duplicates exist and the yaml is valid (thanks to #16!)
I considered adding an "aka" property to include the duplicate names but decided to keep things simple - many of these seem to be names of previously acquired or rebranded companies.
I have not added or removed any account IDs in this process (checked by comparing against main):
If you submit a PR that includes duplicates or schema validation errors:
They will fail the check:
These changes were helpful for me but I completely understand if other people use this resource differently. Also very happy to submit only a subset of these changes if requested!
Thanks for maintaining such a useful resource!
There are some duplicate account IDs in the file due merges, mergers etc. I've found it useful to associate only a single vendor with each account ID as I nearly always want to map an account ID to a vendor rather than vice-versa. I wanted to submit a PR in case these changes would be helpful for anyone else.
I've tried to break this change down into atomic commits that can be easily verified. The summary is:
source:
properties where these are clearly sourcesI considered adding an "aka" property to include the duplicate names but decided to keep things simple - many of these seem to be names of previously acquired or rebranded companies.
I have not added or removed any account IDs in this process (checked by comparing against main):
An example of the github action passing:![Screenshot 2023-10-04 at 18 44 52](https://github.com/fwdcloudsec/known_aws_accounts/assets/140078344/1a1fb2b7-0bf0-4bc2-8290-716a5ba8bd41)
If you submit a PR that includes duplicates or schema validation errors:![Screenshot 2023-10-04 at 18 38 04](https://github.com/fwdcloudsec/known_aws_accounts/assets/140078344/4a1c9de6-3758-4d78-992a-863c759afb72)
They will fail the check:![Screenshot 2023-10-04 at 18 42 11](https://github.com/fwdcloudsec/known_aws_accounts/assets/140078344/cf4ad457-a3d7-4723-a4e0-75d840aba63b)
These changes were helpful for me but I completely understand if other people use this resource differently. Also very happy to submit only a subset of these changes if requested!