Extension does not fire properly on some websites

fwenzel / copy-shorturl

A Firefox extension to quickly create a short URL for the current page and copy it to the clipboard.

https://addons.mozilla.org/addon/copy-shorturl

Apache License 2.0

35 stars 15 forks source link

Extension does not fire properly on some websites #109

Closed fwenzel closed 4 years ago

fwenzel commented 4 years ago

From an add-on review:

Copy ShortURL stopped working for some websites, no matter which shortener you use. Tried "tinyurl.com", "bit.ly" and "is.gd".

Example website where it doesn't work:
"https://rdir.nl.wien.gv.at/form.do?agnCI=16&agnFN=Fullview&agnUID=nc.D.P4.Oj.BEH.BvQ.A.G4t0z_biNivj8qqGq4-QGtoEVVT7FbejDVz7pen4SxKsA9SWtLG0DzS2dsPUEVmF0KStCE3n4T8EEdIyttXHrw"

Pls fix it.

fwenzel commented 4 years ago

Can confirm nothing shows up on the Wien GV website

fwenzel commented 4 years ago

Bug found: On documents that do not have a <title> element, there will be an error.

gsgolfer commented 4 years ago

I removed the older version, closed Firefox 62, reopened and install latest version. The problem still exists for me. Doesn't work on https://www.golf-monthly.co.uk/ or https://www.garmin.com/en-US/

fwenzel commented 4 years ago

I cannot confirm this. Do you get an error in the browser console?

I checked both sites you are highlighting and they work without problem.

But I am using Firefox 74 which is the latest stable version. Why are you using Firefox 62? I will take a quick look, but might have to bump up the minimum version requirements.

fwenzel commented 4 years ago

Ah yes the latest versions do not work with older Firefox anymore. I will adjust the minimum versions.

fwenzel commented 4 years ago

I filed #111 to track minimum version question

gsgolfer commented 4 years ago

As a CEO over a tech company, I don't like the control Firefox is taking from users, and browser security hasen't improved that much. I personally use Browsers for personal business but as a company, we use them for business as well. Many clients can't or haven't upgraded websites to stay current with Mozilla's Firefox upgrade time line, it's too fast. Consequently, many websites don't work properly with Firefox, the reason I went back to v62 and M.Edge is gaining a foothold. Past v62, Firefox progressively eliminates the users ability to control browser updating, some extensions quit working and websites get squirrely. Your 5.0v works seamlessly with 62 and all sites, so I have uninstalled your latest, as it's erratic. I have a Bitly account but it's too complex, but will use it if need be. Hope the problem gets solved because I prefer your extension.

fwenzel commented 4 years ago

Sounds good thank you!

gsgolfer commented 4 years ago

Hello, just checking.. I went to look for your Copy ShortURL extension and it's not listed????

fwenzel commented 4 years ago

You can find older versions here: https://addons.mozilla.org/en-US/firefox/addon/copy-shorturl/versions/ hope this works!