search

fwenzel / copy-shorturl

A Firefox extension to quickly create a short URL for the current page and copy it to the clipboard.
https://addons.mozilla.org/addon/copy-shorturl
Apache License 2.0
35 stars 15 forks source link

Does not work on e10s #42

Closed streetwolf closed 9 years ago

streetwolf commented 9 years ago

When are you going to support e10s? Currently CSurl doesn't work with e10s. The Nightly build will be turning on e10a in a week or two.

fwenzel commented 9 years ago

Oh? Thank you for the heads-up. I didn't know my add-on was incompatible.

Do you know of a good resource of what I might have to change? It's possible I just have to compile it with a new version of the addons SDK. I am not doing anything crazy (i.e., that relies on non-e10s) in this add-on, I think.

streetwolf commented 9 years ago

Unfortunately I have no idea. There must be some Mozilla site that tells you what you have to do. You could always recompile and I'll test it out or you can using the Nightly build.

fwenzel commented 9 years ago

Okay I've tested and it won't work yet because:

% cfx run -b /Applications/FirefoxNightly.app/Contents/MacOS/firefox-bin
Warning: missing module: ../../framescript/FrameScriptManager.jsm
Using binary at '/Applications/FirefoxNightly.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/8t/h66tn3rn3nl253h3cmct4s2r0000gq/T/tmpGib82X.mozrunner'.
console.error: copy-shorturl:
  Message: TypeError: popupNode is null
  Stack:
    isCurrent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/8t/h66tn3rn3nl253h3cmct4s2r0000gq/T/tmpGib82X.mozrunner/extensions/jid0-ODIKJS9b4IT3H1NYlPKr0NDtLuE@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js:113:9
updateItemVisibilities@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/8t/h66tn3rn3nl253h3cmct4s2r0000gq/T/tmpGib82X.mozrunner/extensions/jid0-ODIKJS9b4IT3H1NYlPKr0NDtLuE@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js:1030:49
openPopupAtScreen@chrome://global/content/bindings/popup.xml:67:15
receiveMessage@chrome://browser/content/tabbrowser.xml:3078:15

JavaScript error: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/8t/h66tn3rn3nl253h3cmct4s2r0000gq/T/tmpGib82X.mozrunner/extensions/jid0-ODIKJS9b4IT3H1NYlPKr0NDtLuE@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/context-menu.js, line 458: TypeError: popupNode is null
^CTraceback (most recent call last):
  File "/Users/fred/dev/addon-sdk/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/Users/fred/dev/addon-sdk/python-lib/cuddlefish/__init__.py", line 956, in run
    no_connections=no_connections)
  File "/Users/fred/dev/addon-sdk/python-lib/cuddlefish/runner.py", line 714, in run_app
    time.sleep(0.05)
KeyboardInterrupt

That's a bug in the context-menu SDK module, which does not work on e10s yet. The bug for this is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1060138 .

That's unfortunate, but I figure if we turn on e10s by default on Nightly, this will break quite a few add-ons.

fwenzel commented 9 years ago

Good news, that bug was fixed and in the next version of the Addons SDK, context menu should work again!

streetwolf commented 9 years ago

I’m running on inbound and sure enough it’s working now.

fwenzel commented 9 years ago

Oh wow, that's even faster than I anticipated. And in fact you're right that I don't even need to do anything on my end -- AMO will repackage the add-on when the next version is released as well.

Okay to close this Issue?

streetwolf commented 9 years ago

Close it.