fwenzel / copy-shorturl

A Firefox extension to quickly create a short URL for the current page and copy it to the clipboard.
https://addons.mozilla.org/addon/copy-shorturl
Apache License 2.0
35 stars 15 forks source link

Notification does not show up #81

Closed MDJonas closed 6 years ago

MDJonas commented 6 years ago

I'm using this extension with FireFox 57 -- it's excellent! However, I checked the 'show notification on success," but that doesn't come up anywhere -- that is, there's no confirmation the shortening/copying has been done.

fwenzel commented 6 years ago

Did you press Save? Notifications are the default behavior.

fwenzel commented 6 years ago

Does the copying work right, except the notification does not show up?

screenshot 2017-11-29 16 15 26

Also, what operating system are you on?

MDJonas commented 6 years ago

Yes, the copy function works, but there’s no indiction on the toolbar that the extension actually shortened and copied the URL to the clipboard. It’s not a big deal, but it would be nice to know Copy ShortURL worked without having to wait to try and paste it somewhere.

I’m running the current version of High Sierra, and FireFox 57.

Michael

On Nov 29, 2017, at 5:15 PM, Fred Wenzel notifications@github.com wrote:

Does the copying work right, except the notification does not show up?

https://user-images.githubusercontent.com/87232/33406183-89127632-d520-11e7-85df-ed5ec80ef636.png Also, what operating system are you on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fwenzel/copy-shorturl/issues/81#issuecomment-348040548, or mute the thread https://github.com/notifications/unsubscribe-auth/AgdrQWjfdVWHRee1bZBq-6ksStzSfH3pks5s7fOvgaJpZM4QsK59.

fwenzel commented 6 years ago

Very curious. The screenshot above is the notification I see when I have the setting switched on.

fwenzel commented 6 years ago

Do you see that as well? You say "there's no indication in the toolbar", what are you expecting to see?

MDJonas commented 6 years ago

Hi Fred -

There was no screenshot. But I thought a small dialog would appear at the extension icon showing the successful copy/shortening. For example, right now if I put my pointer on the icon, the Copy URL comes up (see attached screenshot). But when I think click in the icon to copy/shorten, nothing appears.

Michael

fwenzel commented 6 years ago

I suggest you check your settings about system notifications, which I believe Firefox uses. The extension just uses the Firefox API for it and shows the notification you can see in the comment above. If you can't see that, it's probably not the extension that's broken. Sorry!

MDJonas commented 6 years ago

Perfecto — I would never have thought of that. For the most part, I keep notifications OFF (other than email, reminders, etc.). But when I turned on Banner for FF, sure enough, up came the confirmation notice.

Thank you — for your patience, a great extension, and for solving the issue for me.

May the Bluebird of the Holidays fly over you.

Michael

fwenzel commented 6 years ago

I am happy to hear this was it! Have a great holiday season as well!