search

fwenzel / copy-shorturl

A Firefox extension to quickly create a short URL for the current page and copy it to the clipboard.
https://addons.mozilla.org/addon/copy-shorturl
Apache License 2.0
35 stars 15 forks source link

Fails to Fully Preserve Link from Send.Firefox.com #91

Closed mcjathan closed 5 years ago

mcjathan commented 5 years ago

I've been testing Mozilla's new secure file sharing website, send.firefox.com. The website allows you to upload file(s), and then the website provides a URL to the file(s). Here's an example of the URL:

https://send.firefox.com/download/2bd3b635e0/#Z_bT6uYMGtMLvPO-xJV1mg

Copy ShortURL is failing to preserve this link, and all other test links I've created on send.firefox.com. I've tried varying the different options for Copy ShortURL and still haven't been able to get my shortened URL to work properly.

I've also tried varying between the is.gd and tinyurl.com services and still Copy ShortURL is failing to create a proper URL.

I've also bypassed the Copy ShortURL Firefox addon, and instead created shortened links directly at the is.gd and tinyurl.com and bitly.com websites and these links work properly.

It appears that there is a bug in Copy ShortURL.

fwenzel commented 5 years ago

Thank you for the detailed report! I tried it out, and it seems the send.firefox site is doing something weird. I will take a look!

fwenzel commented 5 years ago

I found out what the problem is: send.firefox.com uses an incorrect "og:url" meta info in its header. Which means that link sharing with copy-shorturl is broken, and it would be similarly as broken to share the link on Facebook, for instance.

I might remove og:url matching because it seems brittle and website owners often use it wrong.

mcjathan commented 5 years ago

That's good news, Fred! It's kind of surprising that big, supposedly competent organizations like Mozilla and Facebook would get the header wrong! Anyways, do you expect to release an update soon? Regards, Jeff

----------------------- Original Message -----------------------    From: "Fred Wenzel" notifications@github.com To: fwenzel/copy-shorturl copy-shorturl@noreply.github.com Cc: mcjathan Jeff@BeaconPlanning.com, Author author@noreply.github.com Date: Sat, 13 Apr 2019 18:22:26 -0700 Subject: Re: [fwenzel/copy-shorturl] Fails to Fully Preserve Link from Send.Firefox.com (#91)    I found out what the problem is:send.firefox.com uses an incorrect "og:url" meta info in its header. Which means that link sharing with copy-shorturl is broken, and it would be similarly as broken to share the link on Facebook, for instance. I might remove og:url matching because it seems brittle and website owners often use it wrong. —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/fwenzel/copy-shorturl/issues/91#issuecomment-482909808", "url": "https://github.com/fwenzel/copy-shorturl/issues/91#issuecomment-482909808", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

fwenzel commented 5 years ago

Ah yes, let me do that.

fwenzel commented 5 years ago

Sorry for the delay, version 4.6 is now live!