Song stat cleanup. - Githubissues

fwenzel / tablebot

A turntable.fm bot written in node.js

0 stars 0 forks source link

Song stat cleanup. #10

Closed robhudson closed 11 years ago

robhudson commented 11 years ago

Gather song data when joining the room.
Display song and artist along with stats.
(misc) Log number of listeners and djs when bot starts.

fwenzel commented 11 years ago

So now that you log the DJ numbers etc upon entering the room, I don't think check_dj even still needs to issue a separate roominfo request? In the interest of limiting API traffic, we might just want to keep accurate stats (as I think we already are) and then work off our own numbers rather than kicking off another request every time.

What do you think?

robhudson commented 11 years ago

Let me re-iterate what I think you're saying...

We can adapt the room info call that is in check_dj to only be called after the ready event, and from then on, do our own tracking of djcount and not need to make an extra API call. I.e. add_dj and rem_dj could increment and decrement the initial value we determined on ready.

If so, yeah, I agree. I like that.

fwenzel commented 11 years ago

Yes, you're saying it much better than me :)

Now, I thought that the relevant code was affected by this, but it seems not. I'll file an issue for it then!

fwenzel commented 11 years ago

Ship it!

robhudson commented 11 years ago

:ship: it!

I'm happy to do the djcount clean up and then look at that auto-bop algorithm unless you were intending to.

fwenzel commented 11 years ago

You seem to be having a blast, go right for it :) I'll look at the update command then!