search

fwestenberg / reolink_dev

Home Assistant Reolink addon
MIT License
550 stars 102 forks source link

Can't force webhook registration over http #147

Closed ilyavolodin closed 3 years ago

ilyavolodin commented 3 years ago

Describe the bug When adding a integration in home assistant logs are showing the following:

2021-01-29 22:29:40 INFO (MainThread) [custom_components.reolink_dev.base] Host 192.168.1.181 subscribed successfully to webhook https://homeassistant.home/api/webhook/f78eea31*****

My home assistant is accessible from both https://homeassistant.home (through nginx reverse proxy) and http://homeassistant.home:8312 but no matter what I try integration seems to always register webhook through https and thus does not provide motion detection events.

To Reproduce

Expected behavior I expect integration to default to http protocol for webhook registration

Screenshots If applicable, add screenshots to help explain your problem.

Environment: Please provide useful information about your environment, like:

Additional context I've tried adding integration from both http and https. Results seems to be the same in both cases.

andriej commented 3 years ago

What's your 'internal URL' in HA's configuration? Integration seems to use that.

ilyavolodin commented 3 years ago

Yes, that did it. I had to change internal URL to http in order for the webhook to be registered correctly. Thanks!

matheuscanela commented 3 years ago

hey @andriej your comment saved my life, I couldn't find on the docs about these options, so I believe that it should be added to the README, and include all options that can be changed - what do you think @fwestenberg?

I will clone the repo and raise some PR.

Let me give some details about my use case - I have the main router, which connects to the internet and provide internet to all cameras, in addition, I have another router that connects the cameras network, so all my computers and the raspberry pi are behind the second router, so the webhook was pointing to the internal IP of the PI (behind the second router), which is not accessible from outside.

andriej commented 3 years ago

I think @fwestenberg mentioned that reolink may add https support in firmware upgrade