fwestenberg / reolink_dev

Home Assistant Reolink addon
MIT License
550 stars 102 forks source link

Cannot open live feed from lovelace card. AttributeError: 'ReolinkCamera' object has no attribute '_input' #235

Closed mariusno closed 3 years ago

mariusno commented 3 years ago

Describe the bug When opening the Picture Entity Card Configuration the error occurs. The text "Preview of Camera1 camera" is shown and now live feed is played, error is written to the HA log: "AttributeError: 'ReolinkCamera' object has no attribute '_input'" (See screenshots)

Config is set to: Protocol: RTMP Steam: Tested main and sub Custom thumbnail path: /

To Reproduce Open the card again. Stacktrace from HA: Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 422, in _handle_request resp = await self._request_handler(request) File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 499, in _handle resp = await handler(request) File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 119, in impl return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 77, in forwarded_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 24, in request_context_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 78, in ban_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 144, in auth_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 135, in handle result = await result File "/usr/src/homeassistant/homeassistant/components/camera/init.py", line 511, in get return await self.handle(request, camera) File "/usr/src/homeassistant/homeassistant/components/camera/init.py", line 546, in handle stream = await camera.handle_async_mjpeg_stream(request) File "/config/custom_components/reolink_dev/camera.py", line 199, in handle_async_mjpeg_stream await stream.open_camera(self._input, extra_cmd=self._extra_arguments) AttributeError: 'ReolinkCamera' object has no attribute '_input'

Screenshots image image image image

Expected behavior Live view from camera

Environment:

dpeluso commented 3 years ago

I'm also getting this error.

mariusno commented 3 years ago

I might have been able to solve this issue.

  1. Updated to core-2021-8
  2. Added "stream:" to configuration (https://www.home-assistant.io/integrations/stream/)
  3. Downloaded the v0.19 version again to custom_components

@dpeluso Maybe you can try this to confirm a possible fix?

dpeluso commented 3 years ago

Thanks @mariusno this workout does resolve the error for me too. I'm probably expecting to much but still getting a 10sec lag from cams.