fwestenberg / reolink_dev

Home Assistant Reolink addon
MIT License
550 stars 102 forks source link

2021.9: Breaking change in camera #254

Closed andriej closed 3 years ago

andriej commented 3 years ago

https://rc.home-assistant.io/blog/2021/08/25/release-20219/ - in breaking changes there's a note for custom camera components developers, about adding a height and width

ijustlikeit commented 3 years ago

Reolink cameras are sending warning messages. This needs to be looked at.

Logger: homeassistant.components.camera Source: components/camera/init.py:465 Integration: Camera (documentation, issues) First occurred: 9:10:02 PM (3 occurrences) Last logged: 9:15:51 PM

The camera entity camera.backyard does not support requesting width and height, please open an issue with the integration author The camera entity camera.frontdoor does not support requesting width and height, please open an issue with the integration author The camera entity camera.westside does not support requesting width and height, please open an issue with the integration author

andriej commented 3 years ago

Details are in release note: image

cpainchaud commented 3 years ago

should be fixed with PR https://github.com/fwestenberg/reolink_dev/pull/274 . Waiting for author to issue a release

fwestenberg commented 3 years ago

Just released v0.20!

ijustlikeit commented 3 years ago

Thanks for your work on this!

fwestenberg commented 3 years ago

Thank you too!