search

fwextensions / QuicKey

Jump between recent tabs in Chrome via keyboard shortcuts or a most recently used (MRU) menu.
https://fwextensions.github.io/QuicKey
214 stars 21 forks source link

[Firefox] Issue with Moving Tabs in Tab Tree and other minor issues #89

Open megamorphg opened 1 year ago

megamorphg commented 1 year ago

I noticed a few minor issues on Firefox as per the new release in #64 and jumped at the opportunity to try this extension in Firefox especially for the "move selected tab" feature.

And one of the main reason I was waiting for QuicKey... using the "move the selected tab to the left/right": it works but doesn't honor tree-style tab structure (like Sidebery and TST). The entire tab tree structure becomes flattened from tab origin to destination. This caused a mini-disaster when I tested this and flattened 200 of my tabs which I had to restore from backups haha.

Fixing this (or "enhancing" this) would mean factoring in tree-style tabs, which in itself is another FIrefox Add-On.

However, this combined feature of being able to search for + move a tab to a specific location + on a tab tree may be something closer to QuicKey's reach since all QuicKey it has to do is factor in the tab tree structure similar to how the extension Tab Session Manager does when it creates backups.

This kind of search + move is missing but essential to TST world where there are literally hundreds of tabs in every window and we need to move it to a specific place without dragging around visually searching for the destination.

This is related to this Sidebery issue I've reported.

Anyway, it's awesome that you finally got this to port over! Everything else seems to be working fine but unfortunately I won't make too much use of this yet since I heavily use TST.

fwextensions commented 1 year ago

Thanks for trying out the FF version, and the detailed feedback!

searching doesn't search on both title and URL (only one or the other). I'm not sure if this ever worked this way? It's been a while since I used this in Chrome.

If by "both title and URL" you mean "match against a string made by concatenating the title and URL", then no, it's never worked that way. It's always matched against both title and URL, separately. So if part of your query is in the title and part in the URL, then that won't match.

"change browser shortcuts" buttons don't work. Super low priority, but just FYI.

Yeah, I'd meant to hide that button, but I think got distracted hiding the private browsing stuff, since I couldn't make that work. Thanks for the reminder!

The entire tab tree structure becomes flattened from tab origin to destination.

That's not anything QuicKey is doing. It's just using the browser API to change a tab location. Presumably the same thing happens if you drag a tab in the normal tab bar?

I just tried installing Tree Style Tab and using QuicKey to move tabs, and it seemed to work okay. But I only have 30 tabs open, and didn't try moving across windows.

megamorphg commented 1 year ago

I must have quite the beginner's bad luck there... I'm not able to replicate the issue in basic test environments with some basic scenarios including moving across windows.

But when I move within one my day-to-day profile within nested trees, it occurs. The first 20 seconds are just moving "Toyfo" tab manually and also another Toyfo tab in a different window. It works fine. But when I move the Toyfo within the same tab tree, to right of the active tab, it flattens all the tabs in between them: (30 seconds in) 2022-10-27-1846-19

Let me know if that is enough info or I can keep trying in test environment to make a simpler scenario.

Honestly though at first I misunderstood this move feature as well, I thought it moves any highlighted tabs or the active to the tab selected in the pop-up. (So I misread this feature as the reverse.) That would be super useful too: when I have a bunch of new tabs I just opened and now I want to organize it under a different tab, especially for later. Is that a legit feature request I can make?

Will also make a separate feature request for an option to search via both URL and title because my most frequent search is: I want to limit the search results to a specific subdomain and a title within that domain.