search

fwextensions / QuicKey

Jump between recent tabs in Chrome via keyboard shortcuts or a most recently used (MRU) menu.
https://fwextensions.github.io/QuicKey
214 stars 21 forks source link

Some icons don't show properly. #99

Closed neoOpus closed 1 year ago

neoOpus commented 1 year ago

Github for some reason doesn't appear and internal browser icons also don't show

image

fwextensions commented 1 year ago

Looks like you're using Edge? QuicKey will show whatever the browser returns for a chrome://favicon/ URL, like chrome://favicon/edge://gpu/. I'd have to do special handling for those tabs, which doesn't seem worth it.

The GitHub favicons should show up, though. They're a little hard to see in dark mode, but this is what I get in Edge:

image

Are you using some other extension that changes the GitHub favicon?

neoOpus commented 1 year ago

Hi,

Actually Github icons on Edge Dark theme shows as white

image

I will look for a solution or come with some suggestions.

fwextensions commented 1 year ago

QuicKey will show whatever the tab's current favicon is, as reported by the browser. Other extensions can override that, so that's how they'll show up in QK as well.

Also, when the browser theme changes, the favicon might not update until that tab gets focused again. Here, Chrome is in dark mode, and the first GitHub tab was suspended by another extension, and the bottom one is live.

image

Then I switched the OS to light more, and the lower GitHub icon was still showing the dark mode version:

image

After I switched back to that tab, it updated.

fwextensions commented 1 year ago

Please reopen this if you're able to find a case where the tab has been activated after the browser theme changed, and QuicKey is still showing the wrong icon.