search

fwilliams / scalable-pytorch-sinkhorn

120 stars 7 forks source link

Function implicitly assumes the two pointclouds to have the same number of points #4

Open de-gozaru opened 1 year ago

de-gozaru commented 1 year ago

Hi,

Thanks for the great repo.

I have a question about the choice of w_x and w_y. If these two parameters are not assigned, they will be assigned uniform weights (as done here), however, this line multiplies the weight for y by the ratio of the number of points between the two pointclouds. If for example x have 1.5 more vertices than y, this test will be inevitably be broken!

Does this function assume the pointclouds to have a similar number of points? what is the motivation behind the scaling in L95?

Thank you in advance.

lDairyl commented 9 months ago

same question here