search

fwouts / react-screenshot-test

A dead simple library to screenshot test React components
https://www.npmjs.com/package/react-screenshot-test
MIT License
618 stars 24 forks source link

Inconsistent test failure #301

Closed adbutterfield closed 3 years ago

adbutterfield commented 3 years ago

Added an example of one of the inconsistent failures I'm getting. I looked closer, and it seems like it's the centering of the number in the circle which is off sometimes. I tried to make a more minimal example with just the circle with the number, but it was always passing. So maybe the issue isn't here, but maybe some flexbox bug in whatever you use to render for the screenshots? Maybe some combination effect of having multiple flex containers? Maybe an issue with styled-components not outputting consistent CSS?

Also, it takes me about 4 runs before I get a failure.

Note: I had to upgrade the version of webdriverio, and make a couple code changes for the new version, in order to get the tests to run (which may or may not be something you want to do, and may or may not be correct).

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

adbutterfield commented 3 years ago

My tests have been running/passing consistently lately. No clear reason why...