Closed drahnr closed 2 years ago
drahnr
commented
2 years ago CC @fbatschi could you post your spec, iirc you already got an update for your dock via fwupdate? I suspect that it's either a different dock or there has been no firmware for a while
lohedges
commented
2 years ago There is currently no firmware for this dock in LVFS. As of yesterday (October 14th) there is no firmware available whatsoever, since Lenovo have pulled the Windows version. I only discovered this having finally got access to a Windows laptop in order to update. (What are the chances of the firmware being removed on the same day?)
Having found the latest firmware on the Internet Archive's WayBack machine it turns out that the update wouldn't have worked anyway due to the Digicert issue reported here. (This wasn't obvious since running the installer directly would silently fail. Only when extracting and running manually do you get a log file containing the certificate error.)
I tried getting info from Lenovo chat, but they obviously have no clue as to when an update will be available. This obviously has nothing to do with the fwupd team, just wanted to highlight what an absolute car crash the firmware situation is with this dock. Given the above, I doubt we'll be seeing anything in LVFS soon. I'm close to cutting my losses and going back to the working TB3 dock.
drahnr
commented
2 years ago For cross referencing ease, while somewhat related, https://forums.lenovo.com/t5/Fedora/Fedora-Linux-Thunderbolt-4-Dock-Update/m-p/5173614?page=1#5762965
mrhpearson
commented
2 years ago We have the FW for the USB-c and TBT3 dock (though I think that needs updating now) but not the TBT4 dock yet. The docking team are working on releasing it but hit some issues in the last round of testing that have delayed it being released.
I've asked for an update and ETA. Will try and remember to update here (and in the linked forum topic) but please nag me if you don't hear anything.
lohedges
commented
2 years ago Just to say that the v1.0.13 firmware installer has just been released for Windows and I have managed to update using a friend's Windows laptop. I'll let you know if it solves the flickering/drop-out issue, or any of the other problems that I have been experiencing. (From the README it looks like nothing of significance has changed since v1.0.11, which was released back in August, but didn't work because of the Digicert issue.)
lohedges
commented
2 years ago The firmware update appears to have fixed the flickering and drop-out issue. (I've not experienced any yet, at least.) However, the external displays are still not detected on boot and suspend / resume doesn't work either. (I've experienced a crash, a hang, and a resume with no detection of the external displays.) I have no such issues with the TB3 workstation dock.
mrhpearson
commented
2 years ago Thanks for the update. As a note (as this is the fwupd project) we are expecting that version to be released on LVFS at the beginning of November - there were some issues around 1.0.11 that needing resolving and delayed it being released. Which platform are you testing against - I couldn't spot it in the above.
lohedges
commented
2 years ago Thanks. I am running Arch Linux on a ThinkPad P1 Gen 5. I'm using the proprietary NVIDIA driver, with Optimus Manager managing the switching of graphics cards via the provided kernel parameters. Everything worked fine on the TB3 workstation dock that I was using before. I also have access to a P1 Gen 2 using the same setup and experience the exact same problem.
I recall reading reports of similar issues when I was first trying to debug, i.e. displays not detected on boot or resume. Will try to dig some links up tomorrow.
Happy to provide more system information if needed.
Cheers.
mrhpearson
commented
2 years ago OK - thanks. We haven't done the (Ubuntu) dock cert with the P1G5 yet (still wrapping up the platform enablement - dock cert comes after because docks are....complicated/painful/difficult). I was using my dock with a P1 G3 and G4 previously succesfully though. It's quite possible there are still fixes to come.
lohedges
commented
2 years ago Just an update to say that the screens have been rock-solid for the past few days following the firmware update. No flickering or drop-outs whatsoever.
Following some debugging, I've discovered that the disconnected external displays on boot results from the nvidia-drm modeset=1 option, which is enabled by default with optimus-manager, as it should be to prevent tearing with PRIME. On disabling this option the external displays are correctly detected as connected when the X server starts, but I experience screen flickering and drop-outs. (Much like before applying the latest firmware, in fact.)
I'm not sure if this is in any way related to the dock firmware, so have posted a question on the Arch Forums here, as well as the optimus-manager issue tracker. I might also post the same question on the Linux subsection of the NVIDIA developers forum.
Let me know if you have any thoughts. As mentioned, the exact same setup works with the Thunderbolt 3 Workstation Dock without issue.
lohedges
commented
2 years ago I spoke too soon. The graphical glitches returned today. Although less frequent than before, I am still experiencing an annoying level of flickering and complete drop-out. Coupled with the startup/resume issue, my solution is simply to return to using the TB3 workstation dock. I simply can't afford to waste any more time getting the TB4 dock to work correctly.
jonasbadstuebner
commented
2 years ago I need this update working too. Am I looking at the wrong place or is there still no support for the TB4 dock? (40B0) :/
mrhpearson
commented
2 years ago I'm not sure on the flickering issue; but on the FW update issue the last update from the dock team was:
After LVFS update to 1.8.6, one important notice in command window disappears. Looks like Linux update some setting in Oct which cannot fully compatible to our coding.
They're working on it but that's why it hasn't been released yet :(
jonasbadstuebner
commented
2 years ago Thank you @mrhpearson for this information. Hope this does not take too long...
I would like to share a "solution" (more of a workaround) that worked for me and I am working with right now. 2 external Monitors connected, one over DP, one over HDMI, no flicker. I have a P1 Gen 4 running (K)ubuntu 22.04 and the 40B0 dock (40B00300EU).
5.19.0-051900-generic (using the mainline kernel installer) and uninstalled all kernels after that/younger kernel versions.sudo prime-select nvidiasudo nvidia-settingsDon't take my words for a "How to get it working for you (for now)", but maybe it get's you on a path where it does work after some trial and error? Would make me happy to hear!
drahnr
commented
2 years ago I successfully updated my dockingstation - thanks @mrhpearson for following through :heart: , which was the initial concern of this issue. It never was intended as a place to rant about the state of the firmware itself or provide workarounds for the prior.
@mrhpearson you might want to direct people to a place where one can leave structured bugreports. I at least failed to find one after 5~ish support calls. I assume this repository is generally fine, but I am not sure.
Closing
norru
commented
1 year ago FYI, I have just observed this issue on
- ThinkPad Carbon X1 Gen11
- Debian Sid
- Linux thinkpad-x1-debian 6.1.0-9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.27-1 (2023-05-08) x86_64 GNU/Linux│ ├─Dock Management Controller Information:
│ │ Device ID: b513cf41bc1e11e220c56fcec9b93006bb7a1bc1
│ │ Current version: 10.5
│ │ Vendor: Lenovo (USB:0x17EF)
│ │ Serial Number: 1S40B1ZEZA08GV
│ │ Update Error: Use the MCU to update the DMC device
│ │ GUIDs: 697a6a95-464e-5b90-a46e-73beab89316e ← USB\VID_17EF&PID_30B5
│ │ 9b2a0c77-248f-59ad-afa6-cee22caae03b ← USB\VID_17EF&PID_30B5&REV_1005nico@thinkpad-x1-debian:~/Projects/itadinanta/rust-oids$ fwupdmgr --version
compile org.freedesktop.fwupd 1.8.12
compile com.hughsie.libxmlb 0.3.10
compile com.hughsie.libjcat 0.1.9
runtime org.freedesktop.fwupd-efi 1.4
compile org.freedesktop.gusb 0.3.10
runtime com.dell.libsmbios 2.4
runtime org.freedesktop.gusb 0.4.5
runtime org.kernel 6.1.0-9-amd64
runtime org.freedesktop.fwupd 1.8.12I have installed the latest firmware by booting the device from Windows (double boot, Win11/Debian)
danpawlik
commented
1 year ago It seems that after update fwupd to 1.9.2:
compile org.freedesktop.fwupd 1.9.2
compile com.hughsie.libxmlb 0.3.11
compile com.hughsie.libjcat 0.1.13
runtime org.freedesktop.fwupd-efi 1.4
compile org.freedesktop.gusb 0.4.5
runtime com.hughsie.libjcat 0.1.13
runtime org.freedesktop.gusb 0.4.5
runtime org.freedesktop.fwupd 1.9.2
runtime org.kernel 6.4.0-0.rc5.41.fc39.x86_64And fwupdmgr reinstall on dockstation it helps. No more issue.
│ ├─Dock Management Controller Information:
│ │ Device ID: 70835e1192ddb447c964de775916a4cd505ec3b3
│ │ Current version: 10.13
│ │ Vendor: Lenovo (USB:0x17EF)
│ │ Serial Number: 1S40B0ZDZJ1LKT
│ │ GUIDs: 697a6a95-464e-5b90-a46e-73beab89316e ← USB\VID_17EF&PID_30B5
│ │ bbb89bb3-2452-5ec3-a844-8679647079b5 ← USB\VID_17EF&PID_30B5&REV_1013Earlier I was reinstalling the firmware on fwupd-1.8.15-1 and the update error still appears.
Glad that new version work well. Thank you!
Describe the bug
There is no update path for the "ThinkPad Universal Thunderbolt 4 Dock"
Consequences are that I am hitting a known and fixed issue in a later firmware update regarding issues in multiscreen setups where EDID information is corrupted.
Steps to Reproduce
The versions reference at lenovo are of the following format 1.0.9 or 1.0.11 etc:
There is also no firmware shown
Expected behavior A clear and concise description of what you expected to happen.
fwupd version information Please provide the version of the daemon and client.
Please note how you installed it (
apt,dnf,pacman, source, etc):fwupd device information Please provide the output of the fwupd devices recognized in your system.
Additional questions