fwupd / firmware-lenovo

Missing firmware for Lenovo Thinkpad hardware
121 stars 4 forks source link

lvfs: Embedded Controller update for T15p/P15v Gen 2 being offered on T15g Gen 2 #349

Closed DerDreschner closed 11 months ago

DerDreschner commented 1 year ago

I have a ThinkPad T15g Gen 2 using the latest Linux Mint together with the following versions of fwupd:

➜  ~ fwupdmgr --version                              
compile   org.freedesktop.fwupd         1.8.12
compile   com.hughsie.libxmlb           0.3.6
compile   com.hughsie.libjcat           0.1.9
runtime   org.freedesktop.fwupd-efi     1.4
compile   org.freedesktop.gusb          0.3.10
runtime   com.dell.libsmbios            2.4
runtime   org.freedesktop.gusb          0.3.10
runtime   org.kernel                    6.3.7-060307-generic
runtime   org.freedesktop.fwupd         1.8.12

When I activate lvfs-testing, fwupd wants to install the following update: https://fwupd.org/lvfs/devices/com.lenovo.ThinkPadN38HT.firmware

image

That is wrong, as this update only applies to T15p Gen 2 / P15v Gen 2 and not my T15g Gen 2. I installed it once before recognize this obstacle, but the update itself got aborted by the UEFI before being flashed to the embedded controller (thankfully).

Could someone forward that issue to the correct team at Lenovo? Thanks in advance!

mrhpearson commented 1 year ago

Hi @DerDreschner Would you mind collecting the contents of your ESRT table please:

sudo grep . /sys/firmware/efi/esrt/entries/*/*

I want to confirm if the FW on LVFS is wrong, or if the BIOS is for some reason using the wrong GUID in the ESRT table. Thanks Mark

DerDreschner commented 1 year ago

Hey @mrhpearson,

I don't mind providing any information that can help in that issue. Here is the output:

➜  ~ sudo grep . /sys/firmware/efi/esrt/entries/*/*       
/sys/firmware/efi/esrt/entries/entry0/capsule_flags:0x0
/sys/firmware/efi/esrt/entries/entry0/fw_class:a1392d82-62d5-4e24-863a-0f682993408f
/sys/firmware/efi/esrt/entries/entry0/fw_type:1
/sys/firmware/efi/esrt/entries/entry0/fw_version:65562
/sys/firmware/efi/esrt/entries/entry0/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry0/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry0/lowest_supported_fw_version:0
/sys/firmware/efi/esrt/entries/entry1/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry1/fw_class:666705ce-0624-4943-8738-09829a26c8ee
/sys/firmware/efi/esrt/entries/entry1/fw_type:2
/sys/firmware/efi/esrt/entries/entry1/fw_version:4029286587
/sys/firmware/efi/esrt/entries/entry1/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry1/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry1/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry2/capsule_flags:0x0
/sys/firmware/efi/esrt/entries/entry2/fw_class:e8dddfb5-175b-4ca5-b77a-ddb98c30f0c0
/sys/firmware/efi/esrt/entries/entry2/fw_type:2
/sys/firmware/efi/esrt/entries/entry2/fw_version:65546
/sys/firmware/efi/esrt/entries/entry2/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry2/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry2/lowest_supported_fw_version:65546
/sys/firmware/efi/esrt/entries/entry3/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry3/fw_class:a5aea3ab-1b50-4943-b6c9-04c041980f50
/sys/firmware/efi/esrt/entries/entry3/fw_type:2
/sys/firmware/efi/esrt/entries/entry3/fw_version:16984070
/sys/firmware/efi/esrt/entries/entry3/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry3/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry3/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry4/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry4/fw_class:52c9711e-7a5d-4e8d-ac4a-ba4d920a1008
/sys/firmware/efi/esrt/entries/entry4/fw_type:2
/sys/firmware/efi/esrt/entries/entry4/fw_version:0
/sys/firmware/efi/esrt/entries/entry4/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry4/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry4/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry5/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry5/fw_class:e97c0e4d-defe-4d92-a079-24ebc5168046
/sys/firmware/efi/esrt/entries/entry5/fw_type:2
/sys/firmware/efi/esrt/entries/entry5/fw_version:28
/sys/firmware/efi/esrt/entries/entry5/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry5/last_attempt_version:28
/sys/firmware/efi/esrt/entries/entry5/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry6/capsule_flags:0x0
/sys/firmware/efi/esrt/entries/entry6/fw_class:2f45f824-5964-4cf7-a20e-6b2a1e3e69f0
/sys/firmware/efi/esrt/entries/entry6/fw_type:2
/sys/firmware/efi/esrt/entries/entry6/fw_version:65545
/sys/firmware/efi/esrt/entries/entry6/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry6/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry6/lowest_supported_fw_version:65545
/sys/firmware/efi/esrt/entries/entry7/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry7/fw_class:072c0411-31b3-4e4f-85bc-1e1b5ed55223
/sys/firmware/efi/esrt/entries/entry7/fw_type:2
/sys/firmware/efi/esrt/entries/entry7/fw_version:2754747
/sys/firmware/efi/esrt/entries/entry7/last_attempt_status:1
/sys/firmware/efi/esrt/entries/entry7/last_attempt_version:2754747
/sys/firmware/efi/esrt/entries/entry7/lowest_supported_fw_version:0
/sys/firmware/efi/esrt/entries/entry8/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry8/fw_class:2bece6a9-392e-48de-9cd1-67dc82dcfead
/sys/firmware/efi/esrt/entries/entry8/fw_type:2
/sys/firmware/efi/esrt/entries/entry8/fw_version:22808
/sys/firmware/efi/esrt/entries/entry8/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry8/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry8/lowest_supported_fw_version:1
➜  ~

Please keep in mind that - for whatever reason - the update is marked as successful in fwupd. This is the output from fwupdmgr get-devices for the embedded controllers:

├─Embedded Controller:
│     Device ID:          2292ae5236790b47884e37cf162dcf23bfcd1c60
│     Summary:            UEFI ESRT device
│     Current version:    0.1.10
│     Minimum Version:    0.1.10
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               e8dddfb5-175b-4ca5-b77a-ddb98c30f0c0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─Embedded Controller:
│     Device ID:          36efb79c255f402f619fa9eb53cd659db51f2a04
│     Summary:            UEFI ESRT device
│     Current version:    0.1.9
│     Minimum Version:    0.1.9
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               2f45f824-5964-4cf7-a20e-6b2a1e3e69f0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update

If you need any additional information, just let me know.

David

mrhpearson commented 1 year ago

Thanks - that confirms the ESRT table GUID matches the T15p/P15v FW being offered. So this either means the FW is wrong; or the FW metadata on LVFS needs updating.

Created internal ticket LO-2521 and asking the FW team for their input on what is wrong

Mark

DerDreschner commented 1 year ago

Alright, thanks for your effort and good work! Looking forward for any updates.

David

ChiWei-Chen commented 1 year ago

@DerDreschner , could you help to confirm the current BIOS version of your machine? Since the ESRT could be not accurate, so could you also confirm it in BIOS setup menu(press F1 in preboot stage)? If you are not in the latest, could you give a try update to the latest BIOS? It is supposed to be fixed in 43W(1.24) or later BIOS. Thanks!

DerDreschner commented 1 year ago

@ChiWei-Chen : Sorry for my late response due to personal circumstances.

Yes, I use the latest version 1.26. I flashed it via fwupd. Every previous version (including 1.24) was flashed using the appropriate Windows update file from lenovo.com.

David

ChiWei-Chen commented 1 year ago

@DerDreschner , thanks. Could you provide whole output of fwupdmgr get-devices for the analysis? Thanks!

DerDreschner commented 1 year ago

@ChiWei-Chen: Yeah, of course I can. Here it is:

  ~ sudo fwupdmgr get-devices
LENOVO 20YS000CGE
│
├─11th Gen Intel Core™ i9-11950H @ 2.60GHz:
│     Device ID:          4bde70ba4e39b28f9eab1628f9dd6e6244c03027
│     Current version:    0x00000042
│     Vendor:             Intel
│     GUIDs:              b9a2dd81-159e-5537-a7db-e7101d164d3f ← cpu
│                         30249f37-d140-5d3e-9319-186b1bd5cac3 ← CPUID\PRO_0&FAM_06
│                         a6bd4ca5-75a6-5796-b564-66b5cab1b11b ← CPUID\PRO_0&FAM_06&MOD_8D
│                         d9dd5e77-df17-5bab-b5ec-22827598bfed ← CPUID\PRO_0&FAM_06&MOD_8D&STP_1
│     Device Flags:       • Internal device
│   
├─Battery:
│     Device ID:          f95c9218acd12697af946874bfe4239587209232
│     Summary:            UEFI ESRT device
│     Current version:    1.3.10246
│     Minimum Version:    0.0.1
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               a5aea3ab-1b50-4943-b6c9-04c041980f50
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─Embedded Controller:
│     Device ID:          2292ae5236790b47884e37cf162dcf23bfcd1c60
│     Summary:            UEFI ESRT device
│     Current version:    0.1.10
│     Minimum Version:    0.1.10
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               e8dddfb5-175b-4ca5-b77a-ddb98c30f0c0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─Embedded Controller:
│     Device ID:          36efb79c255f402f619fa9eb53cd659db51f2a04
│     Summary:            UEFI ESRT device
│     Current version:    0.1.9
│     Minimum Version:    0.1.9
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               2f45f824-5964-4cf7-a20e-6b2a1e3e69f0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─GA104M [GeForce RTX 3070 Mobile / Max-Q]:
│     Device ID:          ce4c74a5188d5b9cdb1e72ed32dad2d313c1c999
│     Current version:    a1
│     Vendor:             NVIDIA Corporation (PCI:0x10DE, PCI:0x8086)
│     GUIDs:              402f12fa-651c-57c6-b5c5-cf4e59c4cce7 ← PCI\VEN_10DE&DEV_249D
│                         f32dbf96-ef8c-5105-b143-8755f08f93da ← PCI\VEN_10DE&DEV_249D&REV_A1
│                         fa3b0f74-def0-5478-9d5d-ed2383f36046 ← PCI\VEN_10DE&DEV_249D&SUBSYS_17AA22E1
│                         7f3cd266-1c69-52dc-9a87-639ca9c13c02 ← PCI\VEN_10DE&DEV_249D&SUBSYS_17AA22E1&REV_A1
│                         c7dac7da-12ca-57be-ba1d-8617ec295689 ← PCI\VEN_8086&DEV_9A01
│                         7305c01c-2139-594e-ace6-16ab469a5d85 ← PCI\VEN_8086&DEV_9A01&REV_05
│                         0a5194a7-ae51-56b0-9865-6af40727566a ← PCI\VEN_8086&DEV_9A01&SUBSYS_17AA22E1
│                         41983c7e-f6ef-5389-9fb3-cebe85f4e9fc ← PCI\VEN_8086&DEV_9A01&SUBSYS_17AA22E1&REV_05
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─Integrated Camera:
│     Device ID:          3fa281ddf80d8a06b8ee5d8beb48d38ee95a9627
│     Current version:    59.18
│     Vendor:             Chicony Electronics Co.,Ltd. (USB:0x04F2)
│     Serial Number:      0001
│     GUIDs:              5e9afdd3-1159-5da5-9b47-113b031f5409 ← USB\VID_04F2&PID_B6BE
│                         0b1a0322-5487-5077-a504-999894556b40 ← USB\VID_04F2&PID_B6BE&REV_5918
│     Device Flags:       • Updatable
│   
├─Intel Management Engine:
│     Device ID:          349bb341230b1a86e5effe7dfe4337e1590227bd
│     Summary:            UEFI ESRT device
│     Current version:    240.42.2235
│     Minimum Version:    0.0.1
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               666705ce-0624-4943-8738-09829a26c8ee
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─MZVL21T0HCLR-00BL7:
│     Device ID:          310f45f1f223064b5c16bf6dff31146755a64480
│     Summary:            NVM Express solid state drive
│     Current version:    EL2QGXA7
│     Vendor:             Samsung (NVME:0x144D)
│     Serial Number:      S64PNF0R338885
│     GUIDs:              bec63ed7-a95f-54fe-b8cc-8e9fee64ba5a ← NVME\VEN_144D&DEV_A80A
│                         60c89aac-f321-515b-b419-3cf02aa9d375 ← NVME\VEN_144D&DEV_A80A&REV_00
│                         310f81b5-6fce-501e-acfb-487d10501e78 ← NVME\VEN_144D&DEV_A80A&SUBSYS_144DA801
│                         4d7a2791-106b-5e72-9cfb-8ea3d89f5421 ← NVME\VEN_144D&DEV_A80A&SUBSYS_144DA801&REV_00
│                         c0e40d86-e47a-57fe-8ed1-453e6d83a586 ← SAMSUNG MZVL21T0HCLR-00BL7
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Signed Payload
│   
├─SSD 980 PRO 2TB:
│     Device ID:          04e17fcf7d3de91da49a163ffe4907855c3648be
│     Summary:            NVM Express solid state drive
│     Current version:    5B2QGXA7
│     Vendor:             Samsung (NVME:0x144D)
│     Serial Number:      S69ENF0R854393E
│     GUIDs:              bec63ed7-a95f-54fe-b8cc-8e9fee64ba5a ← NVME\VEN_144D&DEV_A80A
│                         60c89aac-f321-515b-b419-3cf02aa9d375 ← NVME\VEN_144D&DEV_A80A&REV_00
│                         310f81b5-6fce-501e-acfb-487d10501e78 ← NVME\VEN_144D&DEV_A80A&SUBSYS_144DA801
│                         4d7a2791-106b-5e72-9cfb-8ea3d89f5421 ← NVME\VEN_144D&DEV_A80A&SUBSYS_144DA801&REV_00
│                         c8bffd05-1744-5cdd-ad4d-0fbc3b20e3c2 ← Samsung SSD 980 PRO 2TB
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Signed Payload
│   
├─System Firmware:
│ │   Device ID:          a45df35ac0e948ee180fe216a5f703f32dda163f
│ │   Summary:            UEFI ESRT device
│ │   Current version:    0.1.26
│ │   Vendor:             Lenovo (DMI:LENOVO)
│ │   Update State:       Success
│ │   GUIDs:              a1392d82-62d5-4e24-863a-0f682993408f
│ │                       230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
│ │   Device Flags:       • Internal device
│ │                       • Updatable
│ │                       • System requires external power source
│ │                       • Supported on remote server
│ │                       • Needs a reboot after installation
│ │                       • Device is usable for the duration of the update
│ │ 
│ ├─AMT [unprovisioned]:
│ │     Device ID:        8d5470e73fd9a31eaa460b2b6aea95483fe3f14c
│ │     Summary:          Hardware and firmware technology for remote out-of-band management
│ │     Current version:  15.0.42.2235
│ │     Bootloader Version:15.0.42.2235
│ │     Vendor:           Intel Corporation (MEI:0x8086)
│ │     GUIDs:            12f80028-b4b7-4b2d-aca8-46e0ff65814c
│ │                       0ad638e6-06cd-51c3-ab0d-d7f8f7d49418 ← MEI\VEN_8086&DEV_43E0
│ │                       6f7f3333-51b2-5cbe-8c8f-5b7d8032258d ← MEI\VEN_8086&DEV_43E0&REV_11
│ │                       1a29a94a-e2a9-56e1-8191-03340748d4e6 ← MEI\VEN_8086&DEV_43E0&SUBSYS_17AA22E1
│ │                       d15b6ea9-e27a-5dab-bd36-e21a4b9a1c74 ← MEI\VEN_8086&DEV_43E0&SUBSYS_17AA22E1&REV_11
│ │     Device Flags:     • Internal device
│ │   
│ └─BootGuard Configuration:
│       Device ID:        b0d4430dfa6bde9f0c22680df36dbc8c15c80753
│       Current version:  11
│       Vendor:           Intel Corporation (MEI:0x8086)
│       GUIDs:            dd17041c-09ea-4b17-a271-5b989867ec65
│                         0ad638e6-06cd-51c3-ab0d-d7f8f7d49418 ← MEI\VEN_8086&DEV_43E0
│                         6f7f3333-51b2-5cbe-8c8f-5b7d8032258d ← MEI\VEN_8086&DEV_43E0&REV_11
│                         1a29a94a-e2a9-56e1-8191-03340748d4e6 ← MEI\VEN_8086&DEV_43E0&SUBSYS_17AA22E1
│                         d15b6ea9-e27a-5dab-bd36-e21a4b9a1c74 ← MEI\VEN_8086&DEV_43E0&SUBSYS_17AA22E1&REV_11
│       Device Flags:     • Internal device
│     
├─ThinkPad Thunderbolt 4 Dock:
│ │   Device ID:          64d62e2af417c24295829c53e56618e701ab2720
│ │   Current version:    10.13
│ │   Vendor:             Lenovo (USB:0x17EF)
│ │   Serial Number:      1S40B0ZDHN1E5B
│ │   GUIDs:              8d30b09f-bcc5-5379-bc65-9ccceeece1f4 ← USB\VID_17EF&PID_30B4
│ │                       2e4ffb60-b2e2-5f2f-9ea6-60931eed758b ← USB\VID_17EF&PID_30B4&REV_0100
│ │                       275e4695-9b4e-5263-835e-8681bec8cd1a ← USB\VID_17EF&PID_30B4&CID_40B0
│ │   Device Flags:       • Updatable
│ │                       • System requires external power source
│ │                       • Supported on remote server
│ │                       • Device stages updates
│ │                       • Signed Payload
│ │ 
│ ├─Audio Controller:
│ │     Device ID:        46dfbb81585c47218b905f5f6cb0249677ff55a1
│ │     Current version:  49-0E-41
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             e1443fec-2b49-5bd0-b921-662ed11e88df ← USB\VID_17EF&PID_30B4&CID_AUDIO
│ │   
│ ├─Display Port 5:
│ │     Device ID:        d95a2e82ae33a2b7b60eb28fead0f43e5a285f9e
│ │     Current version:  5.06.004
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             755e347f-4ae7-53f8-ad69-45b3e9145ed8 ← USB\VID_17EF&PID_30B4&CID_DP5x
│ │   
│ ├─Display Port 6:
│ │     Device ID:        318e4a38bd9bcd07307ceb47b6125b7a356d1b57
│ │     Current version:  6.05.000
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             a7b49eae-1c1d-5b83-ac90-9bbe78ee39c1 ← USB\VID_17EF&PID_30B4&CID_DP6x
│ │   
│ ├─Dock Management Controller:
│ │     Device ID:        05ee315104e95b51ecfe4755c233ef6f5e29990d
│ │     Current version:  0.1.96
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             3edd934f-9800-59c9-b02a-11be480d72e5 ← USB\VID_17EF&PID_30B4&CID_DMC
│ │   
│ ├─Dock Management Controller:
│ │     Device ID:        d475403f419129b624d66aa835219c69411c66a8
│ │     Current version:  7.41
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             c287973a-cc6b-5d2a-ac71-3956a512f73d ← USB\VID_17EF&PID_30B4&CID_MCU
│ │   
│ ├─Dock Management Controller Information:
│ │     Device ID:        af295629e714e68a295d3a2d830a8bdb4d476dc2
│ │     Current version:  10.13
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     Serial Number:    1S40B0ZDHN1E5B
│ │     Update Error:     Use the MCU to update the DMC device
│ │     GUIDs:            697a6a95-464e-5b90-a46e-73beab89316e ← USB\VID_17EF&PID_30B5
│ │                       bbb89bb3-2452-5ec3-a844-8679647079b5 ← USB\VID_17EF&PID_30B5&REV_1013
│ │   
│ ├─Ethernet Adapter:
│ │     Device ID:        6a1956bb9c4d5b46d0527da4139c25bfc6c7436d
│ │     Current version:  1.73.4
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             abbc9b3e-43fe-538f-bfaf-b7e74b3fd47c ← USB\VID_17EF&PID_30B4&CID_I255
│ │   
│ ├─Power Delivery:
│ │     Device ID:        d61d7daaab308bfca6966dd42a5de6dc17c196fd
│ │     Current version:  12.5.49
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             e83aba6c-99b3-5e87-b982-ba57a1bf750f ← USB\VID_17EF&PID_30B4&CID_PD
│ │   
│ ├─Thunderbolt 4 Controller:
│ │     Device ID:        60a5268504440ea86c28f093ed77f9397ae970d6
│ │     Current version:  38.00.06
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             d6408693-09a5-5f0f-b492-275b5ed16d10 ← USB\VID_17EF&PID_30B4&CID_TBT4
│ │   
│ ├─USB 2 Hub:
│ │     Device ID:        e9e122a6dc1e8a00c1d2221e0781b49d510c05da
│ │     Current version:  V1003
│ │     Vendor:           Lenovo (USB:0x17EF)
│ │     GUID:             4eab6a92-0ec3-5221-ac0b-c841655f7989 ← USB\VID_17EF&PID_30B4&CID_USB2
│ │   
│ └─USB 3 Hub:
│       Device ID:        974384a719462f7e6fc718247f97af986b4d2e32
│       Current version:  5533
│       Vendor:           Lenovo (USB:0x17EF)
│       GUID:             0e5b868b-34a4-5753-8f2e-fe5326494d7a ← USB\VID_17EF&PID_30B4&CID_USB3
│     
├─UEFI Device Firmware:
│     Device ID:          d96de5c124b60ed6241ebcb6bb2c839cb5580786
│     Summary:            UEFI ESRT device
│     Current version:    0
│     Minimum Version:    1
│     Vendor:             DMI:LENOVO
│     Update State:       Success
│     GUID:               52c9711e-7a5d-4e8d-ac4a-ba4d920a1008
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─UEFI Device Firmware:
│     Device ID:          f37fb01122dd62c773f4e84ec89737e059712d59
│     Summary:            UEFI ESRT device
│     Current version:    28
│     Minimum Version:    1
│     Vendor:             DMI:LENOVO
│     Update State:       Success
│     GUID:               e97c0e4d-defe-4d92-a079-24ebc5168046
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─UEFI Device Firmware:
│     Device ID:          11a7fbdd09ce583e58b899660fe10f147fd155a2
│     Summary:            UEFI ESRT device
│     Current version:    2754747
│     Vendor:             DMI:LENOVO
│     Update State:       Failed
│     Update Error:       failed to update to 0: unsuccessful
│     GUID:               072c0411-31b3-4e4f-85bc-1e1b5ed55223
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─UEFI Device Firmware:
│     Device ID:          a083ebc5138e5e071ef7270cc9a8280722cc7adf
│     Summary:            UEFI ESRT device
│     Current version:    22808
│     Minimum Version:    1
│     Vendor:             DMI:LENOVO
│     Update State:       Success
│     GUID:               2bece6a9-392e-48de-9cd1-67dc82dcfead
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
└─USB3.0 Hub:
      Device ID:          cf294bf55b333004beb7c41f952c1838c23e1f4a
      Current version:    38.0
      Vendor:             Intel Corporation. (USB:0x8087)
      GUIDs:              b3f8b518-ebdd-5969-9b44-6b096eff5b9b ← USB\VID_8087&PID_0B40
                          27f4ed60-ed53-52a7-ae28-ea87d9a23302 ← USB\VID_8087&PID_0B40&REV_1234
                          c6e7a14f-f13c-55e5-99de-d59461db1d27 ← USB\VID_8087&PID_0B40&HUB_0000
                          350ec5bb-25c0-543e-8d4c-72c30d2b8df0 ← TBT-01082031
      Device Flags:       • Updatable
                          • Signed Payload

➜  ~
ChiWei-Chen commented 1 year ago

@DerDreschner , I've shared the output to FW team, I'll keep you updated if any progress. Thanks!

ChiWei-Chen commented 1 year ago

@DerDreschner , the FW team wants to have a video (or detail steps) how did you try to update the EC on this system.

They used the commands below to update and the result is pass:

fwupdmgr --force refresh
fwupdmgr --force update  
DerDreschner commented 1 year ago

@ChiWei-Chen : Sure, here is a video with the steps. But it's not a lot. Just activating lvfs-testing and then use the commands you posted.

https://github.com/fwupd/firmware-lenovo/assets/34408442/7c172613-592c-4397-b8a0-25c72ffb8693

In case you need any more information, just let me know!

ChiWei-Chen commented 1 year ago

@DerDreschner , thanks! I'll give you back if any progress from the team.

DerDreschner commented 1 year ago

Hey @ChiWei-Chen, the firmware update team released a new version of the problematic embedded controller firmware to the stable branch. fwupd wants to install it on my T15g Gen 2, although it's clearly compatible. As it's marked as stable, there are no changes to any config files necessary to trigger that behavior on my machine.

image

Let me know if you need any more informations.

ChiWei-Chen commented 1 year ago

@DerDreschner , thanks for the feedback. The FW team still investigating this issue, but they want to know if "load default setting in BIOS" can help with this, could you give it a try? Thanks!

DerDreschner commented 1 year ago

@ChiWei-Chen: Negative. I loaded the default setup settings without any change. I also tried using the OS Optimized Defaults - which are disabled on my machine as I don't want secure boot etc. enabled - without any luck. fwupd still wants to install this firmware update on my machine.

Let my know if you need anything else.

ChiWei-Chen commented 1 year ago

@DerDreschner , thanks, I shared this with FW team. I'll give you update if any progress from the team.

DerDreschner commented 1 year ago

@ChiWei-Chen : FYI, I installed the new update (UEFI: 1.27 / ECP: 1.12) today. Still no change.

ChiWei-Chen commented 1 year ago

@DerDreschner , thanks, I've shared this with the FW team. They're checking this internally.

DerDreschner commented 11 months ago

@ChiWei-Chen : I installed the latest update released today (UEFI: 1.30 / ECP: 1.14). The update isn't offered anymore, although the GUIDs didn't changed. If this is the desired behaviour, you can close this ticket.

 ~ ▓▒░ sudo grep . /sys/firmware/efi/esrt/entries/*/*                                      ░▒▓ ✔ │ 16:14:13 
/sys/firmware/efi/esrt/entries/entry0/capsule_flags:0x0
/sys/firmware/efi/esrt/entries/entry0/fw_class:a1392d82-62d5-4e24-863a-0f682993408f
/sys/firmware/efi/esrt/entries/entry0/fw_type:1
/sys/firmware/efi/esrt/entries/entry0/fw_version:65566
/sys/firmware/efi/esrt/entries/entry0/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry0/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry0/lowest_supported_fw_version:0
/sys/firmware/efi/esrt/entries/entry1/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry1/fw_class:666705ce-0624-4943-8738-09829a26c8ee
/sys/firmware/efi/esrt/entries/entry1/fw_type:2
/sys/firmware/efi/esrt/entries/entry1/fw_version:4029483371
/sys/firmware/efi/esrt/entries/entry1/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry1/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry1/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry2/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry2/fw_class:2f45f824-5964-4cf7-a20e-6b2a1e3e69f0
/sys/firmware/efi/esrt/entries/entry2/fw_type:2
/sys/firmware/efi/esrt/entries/entry2/fw_version:1
/sys/firmware/efi/esrt/entries/entry2/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry2/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry2/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry3/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry3/fw_class:a5aea3ab-1b50-4943-b6c9-04c041980f50
/sys/firmware/efi/esrt/entries/entry3/fw_type:2
/sys/firmware/efi/esrt/entries/entry3/fw_version:16984070
/sys/firmware/efi/esrt/entries/entry3/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry3/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry3/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry4/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry4/fw_class:52c9711e-7a5d-4e8d-ac4a-ba4d920a1008
/sys/firmware/efi/esrt/entries/entry4/fw_type:2
/sys/firmware/efi/esrt/entries/entry4/fw_version:0
/sys/firmware/efi/esrt/entries/entry4/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry4/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry4/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry5/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry5/fw_class:e97c0e4d-defe-4d92-a079-24ebc5168046
/sys/firmware/efi/esrt/entries/entry5/fw_type:2
/sys/firmware/efi/esrt/entries/entry5/fw_version:29
/sys/firmware/efi/esrt/entries/entry5/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry5/last_attempt_version:29
/sys/firmware/efi/esrt/entries/entry5/lowest_supported_fw_version:1
/sys/firmware/efi/esrt/entries/entry6/capsule_flags:0x0
/sys/firmware/efi/esrt/entries/entry6/fw_class:e8dddfb5-175b-4ca5-b77a-ddb98c30f0c0
/sys/firmware/efi/esrt/entries/entry6/fw_type:2
/sys/firmware/efi/esrt/entries/entry6/fw_version:65550
/sys/firmware/efi/esrt/entries/entry6/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry6/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry6/lowest_supported_fw_version:65550
/sys/firmware/efi/esrt/entries/entry7/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry7/fw_class:072c0411-31b3-4e4f-85bc-1e1b5ed55223
/sys/firmware/efi/esrt/entries/entry7/fw_type:2
/sys/firmware/efi/esrt/entries/entry7/fw_version:2951531
/sys/firmware/efi/esrt/entries/entry7/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry7/last_attempt_version:2951531
/sys/firmware/efi/esrt/entries/entry7/lowest_supported_fw_version:0
/sys/firmware/efi/esrt/entries/entry8/capsule_flags:0x8010
/sys/firmware/efi/esrt/entries/entry8/fw_class:2bece6a9-392e-48de-9cd1-67dc82dcfead
/sys/firmware/efi/esrt/entries/entry8/fw_type:2
/sys/firmware/efi/esrt/entries/entry8/fw_version:22808
/sys/firmware/efi/esrt/entries/entry8/last_attempt_status:0
/sys/firmware/efi/esrt/entries/entry8/last_attempt_version:0
/sys/firmware/efi/esrt/entries/entry8/lowest_supported_fw_version:1
├─Embedded Controller:
│     Device ID:          2292ae5236790b47884e37cf162dcf23bfcd1c60
│     Summary:            UEFI ESRT device
│     Current version:    0.0.1
│     Minimum Version:    0.0.1
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               2f45f824-5964-4cf7-a20e-6b2a1e3e69f0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─Embedded Controller:
│     Device ID:          36efb79c255f402f619fa9eb53cd659db51f2a04
│     Summary:            UEFI ESRT device
│     Current version:    0.1.14
│     Minimum Version:    0.1.14
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     GUID:               e8dddfb5-175b-4ca5-b77a-ddb98c30f0c0
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
ChiWei-Chen commented 11 months ago

@DerDreschner , great! Thanks!