fx-world / AudioPreview

Mozilla Public License 2.0
1 stars 0 forks source link

Broken in Thunderbird 128.00esr (64-bit) #1

Open bmn001 opened 1 month ago

bmn001 commented 1 month ago

With this week's Thunderbird update to 128, this addon appears to have stopped working.

Emails will still display correctly in the preview pane, however the audio preview bar never appears.

fx-world commented 1 month ago

I updated from Version 115 to 128.0.1esr and I could not reproduce the error in both versions.

Thunderbird - AudioPreview 2 Thunderbird - AudioPreview 1

Can you please update that minor version as well and try again, and/or send me an email the shows the error, so I can try to reproduce it.

Thank you.

bmn001 commented 1 month ago

I'm using Ubuntu 24.04, so my Thunderbird install was a snap.

However since filing this issue I've disabled the snap and have switched over to using Thunderbird from Mozilla's repository instead, hoping that might fix it.

That did fix it. But doing so took me from 128.00esr (64-bit) down to 115.13.0 (64-bit) where the plugin works without a problem.

So then I uninstalled Thunderbird package, removed the apt repo, and switched over to the Thunderbird Flatpak. That put me on version 128.0.1esr (64-bit) and again the plugin is not working.

I have identified two different emails, one where the player appears and one where it does not.

In the source of the message where the player does appear, the attached wav appears with this header:

Content-Type: audio/vnd.wave; name="sample-3s.wav"
Content-Disposition: attachment; filename="sample-3s.wav"
Content-Transfer-Encoding: base64

In the source of the message where the player does not appear, the attached wav appears with this header:

Content-Type: audio/wav
Content-Transfer-Encoding: base64
Content-Disposition: inline; filename=message.wav
Content-Duration: 21

In the Thunderbird View menu, whether or not I enable "Display attachments inline" does not seem to have any effect.

fx-world commented 3 weeks ago

So I tested the 128.0esr on Ubuntu and it worked without a problem. It is not a problem with the Thunderbird version, it is the difference in the mails. In the mail you say does not work the audio file is not an attachment, but inline. But my code checks for attachments, not inline. I probably will add that as a feature. Problem is I can not really test it, because I could not convince neither Thunderbird, Outlook nor Apple Mail, to generate an inline audio file.

Thunderbird - AudioPreview 3