search

fxbois / web-mode

web template editing mode for emacs
https://web-mode.org
GNU General Public License v3.0
1.63k stars 262 forks source link

Fix byte-compiler warnings #1266

Closed snogge closed 1 year ago

snogge commented 1 year ago

This should fix most of the byte-compiler warnings shown when installing this package on Emacs 29 with native compilation enabled.

fxbois commented 1 year ago

Hi @snogge thank you for this work. Is it compatible with emacs 28 ?

snogge commented 1 year ago

No, it is not :) I checked all my changes against the docstrings but plist-get was not marked as modified in Emacs 29. I'll update the pull request in a little while.

What Emacs versions do you aim to support? The file says

;; Package-Requires: ((emacs "23.1"))

so that was what I was assuming.

snogge commented 1 year ago

I've dropped the plist-get commit, the rest works on Emacs 28 as far as I can tell.

fxbois commented 1 year ago

@snogge if it is possible it would be great to maintain compatibility with emacs >= 23.1

snogge commented 1 year ago

I checked as far back as 23.4, I was not able to build 23.1 on my system. Tests were done with the github actions defined here: https://github.com/fxbois/web-mode/commit/8c744c8c43e7a1a51800a36ceaad6a509b978449 feel free to use them if you want.

snogge commented 1 year ago

Actually, considering the byte-compiler warnings in https://github.com/snogge/web-mode/actions/runs/4075044915/jobs/7020929825 I'm not sure 23.4 works correctly even before my changes.

fxbois commented 1 year ago

Thank you for this.