fxbois / web-mode

web template editing mode for emacs
https://web-mode.org
GNU General Public License v3.0
1.64k stars 260 forks source link

code folding for php and js #479

Closed xiki808 closed 9 years ago

xiki808 commented 9 years ago

I would like to have a command for code folding for PHP and JS. C-c C-f does work fine in HTML blocks but not in other languages. Previously I used to use hs-toggle-hiding, but unfortunately Web Mode does not support HideShow Minor Mode. Any way to achieve this?

Thank you!

fxbois commented 9 years ago

@xikky could ask the hs-toggle-hiding why his minor mode does not work with web-mode I do not intend to add other folding features in web-mode

xiki808 commented 9 years ago

If I'm not mistaken this is a built-in command. I think people who have a habit of hiding code would love to have Hide Show minor mode supported with Web Mode. But well I don't know anything about how these modes are created and have little idea of how much work needed for this. In any case Thank you for making such a great mode!!

fxbois commented 9 years ago

I'll try to look at Hide Show when I have a little time

fxbois commented 9 years ago

@xikky the last commit on master tries to bring some compatibility

fxbois commented 9 years ago

@xikky reopen if needed