search

fxbox / deprecated-taxonomy

This repository has moved.
https://github.com/fxbox/foxbox/
Mozilla Public License 2.0
0 stars 9 forks source link

s/node/service #12

Closed fabricedesre closed 8 years ago

fabricedesre commented 8 years ago

I finally found time to look at that. I like it a lot! I did a s/node/service because I felt that "node" was too abstract. I'm still not a huge fan of "channel" but I don't have a better proposal ("endpoint" doesn't seem better to me).

Bool values are not great in general. Should we rather enforce enums (eg. get_value("door_sensor/state") -> Enum { Closed, Open} instead of -> bool).

Current implementation is to select services/channel that have all the specified tags. Should we also support "one or several of"?Although that can be worked around by adding more specific tags, so no big deal for now.

Yoric commented 8 years ago

I finally found time to look at that. I like it a lot!

\o/

I did a s/node/service because I felt that "node" was too abstract.

You're right, that sounds better.

I'm still not a huge fan of "channel" but I don't have a better proposal ("endpoint" doesn't seem better to me).

Yeah, I think that channel is marginally better than endpoint, but I don't really like either.

Bool values are not great in general. Should we rather enforce enums (eg. get_value("door_sensor/state") -> Enum { Closed, Open} instead of -> bool).

I was considering that, yes. So, sounds good to me. We'll keep bool as ExtBool or something such.

Current implementation is to select services/channel that have all the specified tags. Should we also support "one or several of"?Although that can be worked around by adding more specific tags, so no big deal for now.

I'm not sure I understand the question. Do you mean "one" == "pick any one service/channel that matches the selector" vs. "several of" == "pick all service/channels that match the selector"?

fabricedesre commented 8 years ago

Sorry I was not clear: I meant selecting services/channels that match only one of several tags in the vector of tags in the selector, instead of having to match all tags in the vector.

Yoric commented 8 years ago

Sorry I was not clear: I meant selecting services/channels that match only one of several tags in the vector of tags in the selector, instead of having to match all tags in the vector.

I'm not entirely sure it's useful. I'd say let's wait until we have a specific usecase for that.