search

fxbox / deprecated-taxonomy

This repository has moved.
https://github.com/fxbox/foxbox/
Mozilla Public License 2.0
0 stars 9 forks source link

The mimetype should be an `Id`, rather than a `String`. #18

Closed Yoric closed 8 years ago

Yoric commented 8 years ago

There will probably be very few distinct mimetypes in the system, and we don't want to confuse a mimetype string with something else.

So, in values.rs, in the definition of Binary, we should use Id<MimetypeId> instead of String for the mimetype. This way, once issue #11 has landed, we'll benefit automatically from string caching.

hfiguiere commented 8 years ago

According to commit cd4bf669 this is already done. @Yoric ?

Yoric commented 8 years ago

Right, thanks,