search

fxbox / deprecated-taxonomy

This repository has moved.
https://github.com/fxbox/foxbox/
Mozilla Public License 2.0
0 stars 9 forks source link

Issue #11 Use string cache for Id<T>. #19

Closed azasypkin closed 8 years ago

Yoric commented 8 years ago

Good start :)

azasypkin commented 8 years ago

Good start :)

Ha-ha, especially failed Travis for such a tiny PR :)

azasypkin commented 8 years ago

It seems we can't implement Serialize for Atom as neither of them is in our crate :) I started to play with so called TaxonomyAtom - wrapper around Atom until I find a better solution :)

Yoric commented 8 years ago

Let's start by making only Id<T> use Atom. Then we'll migrate stuff that needs to be atomicized to Id<T>.

Yoric commented 8 years ago

Looks good to me, thanks.

And thanks for taking the opportunity to advance #14 :)

Yoric commented 8 years ago

Also, you are now officially in charge of discussing with @SimonSapin to find a way to not bloat our binary with useless strings :)

azasypkin commented 8 years ago

Looks good to me, thanks. And thanks for taking the opportunity to advance #14 :)

Np! You're so fast :) I was just about to ask if we want Id<T>::new to accept Atom instead of String as an argument :)

Also, you are now officially in charge of discussing with @SimonSapin to find a way to not bloat our binary with useless strings :)

Sure :)