Prerequisites for adding Thinkerbell as an adapter.

[mcav]

@Yoric Updated with the following changes:

• AddRule -> AddThinkerbellRule
• RemoveRule was deleted, turns out it wasn't used
• Changed ThinkerbellRule enum to use a struct instead of String, String

I have not changed the GenericError object, as it seems like that could be reasonably addressed in a followup.

[Yoric]

RemoveRule was deleted, turns out it wasn't used

Weird. How do you handle rule removal?

I have not changed the GenericError object, as it seems like that could be reasonably addressed in a followup.

Makes sense.

[Yoric]

Looks good to me, with the remarks above.

[mcav]

How do you handle rule removal?

The 'remove' setter is currently of type ChannelKind::Ready. It doesn't need any associated data, because every setter maps to exactly one Rule. We could add another ChannelKind, I guess, but the other ChannelKind values are quite generic so I wasn't sure which route we wanted to take.

[Yoric]

I'd go for something more specific. When the client wishes to remove a rule, they'll look for all the getters of ChannelKind::RemoveThinkerbellRule.

Of course, we still need a good story for determining which rule they are removing. I don't know how we can handle that properly yet.