Tags persistence

[fabricedesre]

@Yoric this is not complete yet... Missing:

• Synchronizing tags with the db when add_getter() and add_setter() are called in backend.rs. It's not super clear to me where we keep the channel tags though. Why are we keeping the service tags in GetterData and SetterData?
• Tests in backend.rs

[Yoric]

Synchronizing tags with the db when add_getter() and add_setter() are called in backend.rs. It's not super clear to me where we keep the channel tags though. Why are we keeping the service tags in GetterData and SetterData?

Because there are selectors that let use query channels based on the service tags.

[fabricedesre]

This updates tags when adding getters and setters. I still need to add backend tests, so I'm not really confident this works.

[Yoric]

I assume that this is not going to be finished in time for demos, so we'll need the demo script to set up the tags.

[fabricedesre]

@Yoric I think I addressed all your comments. Still working on adding backend tests...

[coveralls]

Coverage increased (+4.7%) to 6.609% when pulling fdae71f33f602ba35a598ec6abaf071d435d081c on fabricedesre:tag-persistence into 42b53b1935729668ba31d004f7a1bc2cd305fa8c on fxbox:master.

[coveralls]

Coverage increased (+4.8%) to 6.719% when pulling 58abb9c3c2e2b77d9f3ad03999109a0981ace9ba on fabricedesre:tag-persistence into 42b53b1935729668ba31d004f7a1bc2cd305fa8c on fxbox:master.

[coveralls]

Coverage increased (+4.8%) to 6.719% when pulling e7ed7caf3f54593c9e53a5846547970ee040e7ec on fabricedesre:tag-persistence into 42b53b1935729668ba31d004f7a1bc2cd305fa8c on fxbox:master.

[coveralls]

Coverage increased (+4.8%) to 6.677% when pulling 498bc55e0d985cb75d66b1951921bfc85b70df41 on fabricedesre:tag-persistence into 42b53b1935729668ba31d004f7a1bc2cd305fa8c on fxbox:master.

[coveralls]

Coverage increased (+4.8%) to 6.677% when pulling 498bc55e0d985cb75d66b1951921bfc85b70df41 on fabricedesre:tag-persistence into 42b53b1935729668ba31d004f7a1bc2cd305fa8c on fxbox:master.

[fabricedesre]

r? @Yoric I think this is ready now.

[coveralls]

Coverage increased (+4.8%) to 6.677% when pulling 6220110dbd1caf669d3556ab2ed4a4af755b7a48 on fabricedesre:tag-persistence into 8711223106dae8a74deb367e84f4a85491200486 on fxbox:master.

[Yoric]

@fabricedesre In the future, can you wait until I have set the label "Ship It" before merging?

[fabricedesre]

Sure, but your only comment was a comment nit and the github flow is far from being clear.

[Yoric]

Sure, I just hadn't had time to finish the review. That's why I always set the label "Review: Ship It" or "Review: Not Ready" once I'm done.

[fabricedesre]

fair enough. Let's do whatever follow up we need.

[Yoric]

Sounds good to me.