fxbox / deprecated-taxonomy

This repository has moved.
https://github.com/fxbox/foxbox/
Mozilla Public License 2.0
0 stars 9 forks source link

We need a way to properly shutdown the adapters #74

Closed julienw closed 8 years ago

julienw commented 8 years ago

Currently drop functions are not called. This is likely because we don't stop the several threads we're running. One way to do this is to make the SHUTDOWN_FLAG public so that every threads can access it. But it wouldn't be nice for adapters that are in separate repositories.

Another way is to use a "stop" method on adapters, that would be called at the right time.

The openzwave adapter badly needs this.

Yoric commented 8 years ago

What's SHUTDOWN_FLAG?

I'll add a stop method.

julienw commented 8 years ago

I was refering https://github.com/fxbox/foxbox/blob/28b7a54d88f8fd3aad527cca335edfccf6cbdf64/src/main.rs#L170