search

fxbox / dns-server

Server that helps the Box to announce its local IP address without relying on mDNS, and to register its LetsEncrypt cert for use on its local IP address.
4 stars 2 forks source link

Basic implementation, fixes #1 #2

Closed michielbdejong closed 8 years ago

michielbdejong commented 8 years ago

r? @samgiles @ferjm

michielbdejong commented 8 years ago

@ferjm can you review? There is still quite a bit of room for improvement, I'll do follow-up tickets for things like adding more tests, dealing with malformed queries to both API and DNS interface, using Mocha/Chai for tests, running tests on a port other than UDP port 53 (I think this is an upstream problem).

ferjm commented 8 years ago

LGTM! Just a few minor comments.

michielbdejong commented 8 years ago

Thanks!!