search

fxbox / foxbox

The FoxBox daemon
Mozilla Public License 2.0
29 stars 29 forks source link

Expose manufacturer and model names to the services/list.json #82

Closed gmarty closed 8 years ago

gmarty commented 8 years ago

That'd be nice to have the name of the manufacturer and the model ID of each services in list.json. This can be used to display specific icon to help users to identify devices quicker.

cc @fabricedesre and @cr

Yoric commented 8 years ago

Just to be clear, services/list.json is the placeholder until we have an official REST API for requesting nodes, right?

If so, @gmarty, it would be great if you could also start filing these issues to fxbox_taxononomy.

mcav commented 8 years ago

Is this still valid, in light of alleged plans to move away from services/list.json?

fabricedesre commented 8 years ago

I don't think it is. Closing.

gmarty commented 8 years ago

Please unclose this bug. It's still relevant to services/list. We need to expose more data about the services so that the app looks better.

Alternatively, we can list them in the service/id/state response.

Yoric commented 8 years ago

Note that this will eventually move to /api/*, instead of /services/, once that is implemented.

fabricedesre commented 8 years ago

@gmarty So which details do you need exactly?

gmarty commented 8 years ago

@fabricedesre At least the manufacturer and the model name of the devices. Phillips has a nice set of SVG icons for all the products in the Hue range. Displaying this icon somewhere in the app will help the user to identify the device quicker.

Also the Hue API makes a distinction between attributes (immutable) and state (that change over time) of each devices. Both are clearly separated in the response and we probably need something similar.

azasypkin commented 8 years ago

I'll take it, as we've agreed I'll expose manufacturer, type and model via ServiceSetttings::custom_properties BTreeMap.