search

fxbox / registration_server

The registration server to help with foxbox discovery
4 stars 4 forks source link

Add tunnel url to registry. r=fabrice #11

Closed ferjm closed 8 years ago

ferjm commented 8 years ago

Given that the storage content is really not valuable for us, we can safely remove the existing sqlite file from the dev server before applying these changes.

r? @fabricedesre

michielbdejong commented 8 years ago

@ferjm can we also add the public-local URL? So the Box would post something like the JSON I described in https://github.com/fxbox/foxbox/pull/77#issuecomment-196216450

michielbdejong commented 8 years ago

In fact, I'm thinking, why impose a schema at all? We could just make this service a lot "dumber", just a message bus where anybody can broadcast a message, and anybody can see which messages were sent from the same outgoing IP address.

That makes it a lot clearer what the assumptions are, and it decouples the code of this server from the function we use it for.

michielbdejong commented 8 years ago

I'm still thinking, why impose a schema at all? We could just change local_ip to msg, that way the Box can decide which message string it wants to announce via this service.

ferjm commented 8 years ago

Yes, we could do that.

@fabricedesre any objection?

fabricedesre commented 8 years ago

We can't let clients send arbitrary large message and basically use the registration server as a poor man's db. So I'm fine with having a more relaxed schema, but we can't be fully open ended I fear.