search

fxcosta / laravel-chartjs

Simple package to facilitate and automate the use of charts in Laravel 5.x using Chartjs v2 library
486 stars 112 forks source link

support_php56 #28

Closed pjeutr closed 7 years ago

pjeutr commented 7 years ago

Hi

I'm using PHP 5.6.29-0 and tried the php56 branch. FatalErrorException in Builder.php line 118: Can be easy fixed by removing : self

fxcosta commented 7 years ago

@pjeutr the master branch is correct with php5.6 support. ignore this hotfix branch, everything is merged :dancing_men:

pjeutr commented 7 years ago

Nope, it's also in the master. Tried that first.

fxcosta commented 7 years ago

@pjeutr I need to implement unit testing urgently. I'm sorry, now its fully supported by php 5.6

pjeutr commented 7 years ago

No worries! Thank you for this handy wrapper btw