search

fxcosta / laravel-chartjs

Simple package to facilitate and automate the use of charts in Laravel 5.x using Chartjs v2 library
485 stars 113 forks source link

Making things DRY #31

Closed pjeutr closed 7 years ago

pjeutr commented 7 years ago

Don't know which way you want to go, but because I'm too lazy to retype lineChartTest etc ;) I made it optional to use 'element' And to make things more DRY I also 'generate' the canvas tag in chart-template.blade.php

I can imagine not all people like this. And it certainly breaks stuff, If you do a blind update. Just throwing it in to make a suggestion. And it works for me nicely.

fxcosta commented 7 years ago

@pjeutr nice work! great! Can you modify the documentation with the new examples?

pjeutr commented 7 years ago

@fxcosta Glad you like it! I just changed the documentation

fxcosta commented 7 years ago

@pjeutr thanks for contribution ❤️