fxe025 / pe

0 stars 0 forks source link

No mc limits for each semester #3

Open fxe025 opened 2 months ago

fxe025 commented 2 months ago

By right I shouldn't be able to add 52 mcs all into one semester of study

CEG Study Plan for: Fu Xueer
_____________________________________________________________
| Y1S1 [Sem 1] | Y1S2 [Sem 2] | Y2S1 [Sem 3] | Y2S2 [Sem 4] |
|ES2631        |              |              |              |
|CS1010        |              |              |              |
|GEA1000       |              |              |              |
|DTK1234       |              |              |              |
|EG1311        |              |              |              |
|IE2141        |              |              |              |
|EE2211        |              |              |              |
|CDE2501       |              |              |              |
|CDE2000       |              |              |              |
|PF1101        |              |              |              |
|CP3880        |              |              |              |
_____________________________________________________________
| Y3S1 [Sem 5] | Y3S2 [Sem 6] | Y4S1 [Sem 7] | Y4S2 [Sem 8] |
_____________________________________________________________
- Current Study: Semester 8
- Total MCs taken: 52.00 / 160
- Total MCs listed: 52.00 / 160
_____________________________________________________________
nus-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

GPA can affect maximum Mcs taken

if my GPA is below a certain value, I'm not allowed to overload in current semester.

CEG Study Plan for: Fu Xueer
_____________________________________________________________
| Y1S1 [Sem 1] | Y1S2 [Sem 2] | Y2S1 [Sem 3] | Y2S2 [Sem 4] |
|ES2631      F |              |CG1111A       |              |
|CS1010        |              |LAJ1201       |              |
|GEA1000       |              |LAJ2201       |              |
|DTK1234       |              |LAJ2202       |              |
|EG1311        |              |              |              |
|IE2141        |              |              |              |
|EE2211        |              |              |              |
|CDE2501       |              |              |              |
|CDE2000       |              |              |              |
|PF1101        |              |              |              |
|CP3880        |              |              |              |
|CS2040C       |              |              |              |
_____________________________________________________________
| Y3S1 [Sem 5] | Y3S2 [Sem 6] | Y4S1 [Sem 7] | Y4S2 [Sem 8] |
_____________________________________________________________
- Current Study: Semester 8
- Total MCs taken: 72.00 / 160
- Total MCs listed: 72.00 / 160
_____________________________________________________________
gpa
_____________________________________________________________
Your current GPA is: 0.00
_____________________________________________________________

can consider implementing this feature.


[original: nus-cs2113-AY2324S2/pe-interim#1277] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did not account for this as there are multiple conditions, limitations and exceptions that each student can request to their home faculty that can affect their maximum or minimum workload. Even if the user's GPA is not high enough, if he can provide a valid reason to home faculty, he could still get a maximum workload waiver. Given that users are able to apply for maximum workload waiver and it is subject to the faculty's approval (there is even precedence of 40MCs in 1 semester), we do not restrict the number of modules a user can add in a semester, leaving up to the users discretion to keep track of the number of modules they add to each semester. This is also the design choice done by nusmods, where they do not restrict the amount of mods one can add when planning for a semester. Therefore based on the aforementioned reasons, this issue is rejected.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Adding GPA as one condition to change allowable workload can be a separate feature of itself. For example, the default maximum workload allowed for NUS students is 23 mcs and students are not required to take any actions. However, implement the mc limit (23 mcs) does not mean the program can now adjust this limit to a different value according to students' conditions (eg. approval from home faculty).


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** As mentioned in the bug "GPA can affect maximum Mcs taken", from the user's perspective, implementing a mc limit could be useful in notifying students when their workload is different from the standard workload permitted. In addition, the number of mcs I allocate in Sem 1 in the example is 56, even more than students with waivers. For students who are not familiar with NUS registration system, they would not be alerted by this app that this schedule is infeasible.