search

fxfactorial / podge

:moneybag: A Hodgepodge of functions for living in the OCaml ecosystem
http://hyegar.com
62 stars 6 forks source link

Rough port to ocaml 4.06.1 with the safe-string mode as default. #6

Closed tmcgilchrist closed 5 years ago

tmcgilchrist commented 6 years ago

See https://github.com/ocaml/ocaml/pull/1252.

Pretty quick fixup of bytes/string changes to work with 4.06.1.

Happy to clean up further, I mostly just followed the compiler and did the conversion where it asked for it. Possibly a better approach would be to work inside one particular type and convert on the edges if required.

carlosdagos commented 5 years ago

Tested this using 4.07.0 and it compiles (and works) as well.

Any reason why this can't be merged? :) Thanks

fxfactorial commented 5 years ago

Sorry will merge in morning , also open to other maintainers having repo access

Sent from my iPhone

On Oct 1, 2018, at 8:40 PM, carlosdagos notifications@github.com wrote:

Tested this using 4.07.0 and it compiles as well.

Any reason why this can't be merged? :) Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

carlosdagos commented 5 years ago

Thanks @fxfactorial

Re: repo access/maintaining, I'd be keen but I'm very much an Ocaml newbie so I don't know whether I could do it reliably at this time 😄Cheers