search

fxmontigny / ng2-ace-editor

Ace editor integration with typescript for angular 4 - 5
MIT License
199 stars 92 forks source link

Remove html brace definition as a default #107

Closed SergeyCherman closed 5 years ago

SergeyCherman commented 5 years ago

Currently ng2-ace-editor imports html mode by default. If a user of the component doesn't need html mode it still pulls it in, inflating the bundle size. I suggest bumping the major version after this commit so that existing users aren't impacted.

evgenius1424 commented 5 years ago

Nice fix. Any progress?

SergeyCherman commented 5 years ago

@fxmontigny Anything I can do to get this merged?

SergeyCherman commented 5 years ago

@fxmontigny Anyway to get this merged? I'd rather not create another fork for ng2 ace.

fxmontigny commented 5 years ago

Hi, I can't build a new version because my build script are broken. I need to find why 😢 . I try tomorrow.

SergeyCherman commented 5 years ago

Thanks! Let me know if it's something I can look at. Happy to help!

fxmontigny commented 5 years ago

Thanks @SergeyCherman can you try my new branch https://github.com/fxmontigny/ng2-ace-editor/tree/features/angular_7 ? thx

SergeyCherman commented 5 years ago

LGTM, tested it and no more Peer Deps warnings! I can't try running the project since when using a git branch in package.json it won't work since it doesn't pull in the peer deps, but it should be fine once published on npm.

Can you bump the version on this? I suggest bumping major version to not break it for anyone how's assuming minor/patch updates won't break their projects.

fxmontigny commented 5 years ago

Yes you right.This is more simple.

I have create a new version 0.3.9. Can you try it?

SergeyCherman commented 5 years ago

Yes, this works! Thanks!