fxnoob / mark-incognito

A chrome extension to help users with managing domains to incognito mode only
https://fxnoob.github.io/mark-incognito/Main.html
30 stars 4 forks source link

Feature Request:- Being able to use either url or domain as marker #22

Open vipulbhj opened 4 years ago

vipulbhj commented 4 years ago

In the options page, we should support an option to either mark a specific url or a domain itself to be used as mark incognito and based on that the interception algorithm should change for those given assets.

Use Case : -

For blogging websites like Medium, I want to open all urls from that domain in incognito mode and this feature will give us the flexibility to do that. This will also be useful in banking, etc.

The implementation can be done in a few different ways @fxnoob @HurricaneInteractive @0xflotus let me know what do you guys think about this feature and if you wanna discuss the best way forward.

HurricaneInteractive commented 4 years ago

That does sound like a really good idea. (I haven't seen / worked on the options page) My first idea would be to store more information with the link. In this case almost a "wildcard". I know the chrome storage is a key/value, however, you can always JSON.stringify and then convert it back.

Then when the comparing is done, you'll test if it is a wildcard match or just a full URL match and proceed with the opening in incognito or ignore the link.

fxnoob commented 4 years ago

Best way should be to store more information with the link as @HurricaneInteractive said. So store original url with one more property named as all eg. {url:"", all:"true|false"}. so there would be two option in context menu 1 for saving the domain and 2 would be for saving exact url. Please revert the changes from unchanged files eg. option-page files.

fxnoob commented 4 years ago

@vipulbhj are you working on suggested changes?

vipulbhj commented 4 years ago

@fxnoob didn't get any time today. I be back on regular schedule from tomorrow.

fxnoob commented 4 years ago

Screenshot 2019-11-02 at 8 02 58 PM @vipulbhj, Is this ok view?

vipulbhj commented 4 years ago

Yes, looks great :)