fxos-components / fxos-fastlist

https://fxos-components.github.io/fxos-fastlist/examples
3 stars 3 forks source link

Added background gradient for fast-scrolling (closes #26) #27

Closed wilsonpage closed 9 years ago

wilsonpage commented 9 years ago

Seems to add ~50-80ms to a refresh tick. This patch applies the gradient in phase2, so this won't block first paint or content being interactive.

wilsonpage commented 9 years ago

@etiennesegonzac r?

etiennesegonzac commented 9 years ago

<3 the choice of gradient :) Looks like we need to offset the background though for the "search field" use case. (otherwise it looks like the field is fast scrolling :))

wilsonpage commented 9 years ago

@etiennesegonzac ah I see :) It's not that easy/possible to offset a repeating gradient is it? The simplest fix would be to apply a background-color to the search component. Any other suggestions?

etiennesegonzac commented 9 years ago

I wonder if a subtle use of background-position and repeating-linear-gradient could help, but applying a background color to the search component sounds good too :)

wilsonpage commented 9 years ago

@etiennesegonzac fixed the offset issue by programmatically drawing the gradient. Tested too.

wilsonpage commented 9 years ago

Happy to merge if you are :green_heart:

etiennesegonzac commented 9 years ago

Ship it!

wilsonpage commented 9 years ago

:ship: ed

etiennesegonzac commented 9 years ago

:)