Closed gasolin closed 9 years ago
Looks good! I spotted a visual bug:
The border on the left should be a vertical line, not rounded. This may be nothing to do with your patch, but thought I'd raise it.
mmm... It because we set divided
class in <gaia-switch class="divided"></gaia-switch>
, so the divided
inherit gaia-switch's border-radius: 18px
. add
::content .divided {
border-radius: 0 !important;
could quick fix it, but !important is a bed smell though..
Consider https://bugzilla.mozilla.org/show_bug.cgi?id=1160964 , UX request if the list has a separator, the animation should not cross the separator, so we have to reconsider how we handle divider now.
… travis test