search

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

Fix method implementation #206

Closed AnikanovD closed 8 years ago

AnikanovD commented 8 years ago

https://github.com/composer/composer/commit/623c0dcda7a29a06d21e9736527b05ca436d0f4b

In method ComposerRepository::whatProvides() was added a new parameter. After composer self-update, it began to throw an exceptions

[ReflectionException]                                                   
Class Fxp\Composer\AssetPlugin\Repository\NpmRepository does not exist  

[ErrorException]                                                                                                                                                                                            
Declaration of Fxp\Composer\AssetPlugin\Repository\AbstractAssetsRepository::whatProvides() should be compatible with Composer\Repository\ComposerRepository::whatProvides(Composer\DependencyResolver\Pool $pool, $name, $bypassFilters = false)
francoispluchino commented 8 years ago

Duplicate with 90ea5357652eba9bd8272cc374eda46ce6625df1 and #205.

AnikanovD commented 8 years ago

@francoispluchino, could you explain why merged #205 instead this pr, and create https://github.com/francoispluchino/composer-asset-plugin/commit/9ea76dd2cb1717a5645cf5b499598ed282db8f98, https://github.com/francoispluchino/composer-asset-plugin/commit/90ea5357652eba9bd8272cc374eda46ce6625df1? i'm a newbie in the open source, and maybe don't understand guidelines.

francoispluchino commented 8 years ago

Because, it is preferable to specialize each PR, and fix problem by problem, or add feature by feature.

I hope I am clear enough :-).

AnikanovD commented 8 years ago

Clear enough :) Thanks for the reply.