search

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

support wrong versioning in project #229

Closed devthejo closed 8 years ago

devthejo commented 8 years ago

eg: composer require bower-asset/jquery.layout

francoispluchino commented 8 years ago

If there is a bug with the version converter, it must be fixed, not skipped.

devthejo commented 8 years ago

I agree in theory but if you are not the owner of the repository it can be problematic, et par ailleurs, bower have no problem with that, I think you want to offer a substituion of bower usage and if

bower install jquery.layout

works

composer require bower-asset/jquery.layout

should work too, or I'm wrong ?

francoispluchino commented 8 years ago

Yes, of course, but your fix is not correct. Add your problematic convestion of verion in SemverConverterTest, and fix it.

devthejo commented 8 years ago

Ah ok, j'étais justement en train de me dire que j'avais mal compris, my bad, I will take a look

devthejo commented 8 years ago

I fixed it

francoispluchino commented 8 years ago

Thanks to rebase your PR in 1 commit.

francoispluchino commented 8 years ago

And clean your style of code, use php-cs-fixer.