search

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

"asset-pattern-skip-version" must be set in order to skip patches but it should be default as mentioned in the docs. #252

Closed nadar closed 6 years ago

nadar commented 7 years ago

Since version 1.2.* of fxp (on Ubuntu 16.10)

$ composer global show
Changed current directory to /home/nadar/.composer
fxp/composer-asset-plugin v1.2.1 NPM/Bower Dependency Manager for Composer

I have to add the skip pattern version addition to all my composer.json files on every project, like this:

"extra": {
     "asset-pattern-skip-version": "(-build|-patch)"
},

otherwise it takes almost forever to run composer update:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Reading bower.json of bower-asset/angular (v1.4.2-patch4066)^C

As i could see in the docs:

By default, the plugin does not import the patch versions for increase dramatically performance. However, it is possible to change the pattern or to disable this feature.

This confuses my, cause i have to integrate it to all my projects composer.json. I already mentioned that in a comment of a closed issue: https://github.com/fxpio/composer-asset-plugin/issues/240#issuecomment-239132131

So maybe its wrong in the docs, or it does not work, or what else could be the case that i have the explicit override default settings in order to work?

francoispluchino commented 7 years ago

Indeed the doc is not updated.

nadar commented 7 years ago

So its not a mistake and i have to extend all composer.json files of all my projects?

schmunk42 commented 7 years ago

I'd also say that a default with

"asset-pattern-skip-version": "(-build|-patch)"

would be the right choice.