search

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

Could not parse version constraint >=~2: Invalid version string "~2" when installing fullcalendar-scheduler #277

Closed senguttuvang closed 7 years ago

senguttuvang commented 7 years ago

I encountered this issue when attempting to install fullcalendar-scheduler package.

[UnexpectedValueException] Could not parse version constraint >=~2: Invalid version string "~2"

I tried several variations of the following command to workaround the version issue but nothing helps.

composer require bower-asset/fullcalendar-scheduler

francoispluchino commented 7 years ago

It's fixed in the 1.3.0@dev version of this plugin (see 623fe6b9bb28fa23b64efc208d53d6d3fcf84170).

dxops commented 7 years ago

@francoispluchino it has an impact on all packages, require dev-master is not so good solution, are you able to tag new release?

francoispluchino commented 7 years ago

Use the dev-master#2b652ae00f9a59e013d5359301e0bda9ec8be873 version with the SHA to lock the version. The release of the 1.3.0 version is not for tomorrow, but not in a very long time (see the milestone).

dxops commented 7 years ago

So, I have to make a patch release with dev-master ref and another one for 1.3.0 release? It's not so easy in our case. We are waiting for a release for a week already. Can we tag 1.2.3 or 1.3.0 and 1.4.0 for issue in current milestone?

francoispluchino commented 7 years ago

Probably for the next versions but not for the 1.2 version. I will not patch and maintain a old branch just for a few days. I understand your point of view, and I also prefer to use a stable version instead of a branch, but you can consider the 1.3.x-dev version as stable. It just lacks a feature. Thanks for your understanding.

holtkamp commented 7 years ago

Thanks for your understanding. I understand and can live with it, already happy it was fixed very quick!

Just a question though, this is where the PATCH version of Semantic Versioning is for, right? So dev-master#2b652ae00f9a59e013d5359301e0bda9ec8be873 can be tagged as 1.2.3 and pronto? No need for maintenance etc? Or am I thinking too simple / missing some aspects of version management?

dxops commented 7 years ago

@holtkamp commits before the fix https://github.com/fxpio/composer-asset-plugin/compare/v1.2.2...master are not semver compatible with 1.2.3 version. Configuration was changed and looks like that is a BC, so requires major version IMO

francoispluchino commented 7 years ago

@holtkamp See the difference between the v1.2.2 and v1.3.0@dev.

francoispluchino commented 7 years ago

@sergeyz YES!

francoispluchino commented 7 years ago

Several new features have been added, as well as the change to the configuration (with retrocompatibility and depreciation message). I can to postpone the last feature in progress to release the stable version, but I don't want to start maintaining 2 branches.

holtkamp commented 7 years ago

ok, understood!

dxops commented 7 years ago

@francoispluchino lets tag 1.3.0 right now and 1.4.0 once https://github.com/fxpio/composer-asset-plugin/pull/278 merged. This issue is a blocker in most cases and already took almost a month for fix.

francoispluchino commented 7 years ago

@sergeyz I am thinking of doing it.

francoispluchino commented 7 years ago

@sergeyz The v1.3.0 version is released.