Fetaure/skip asset update 2

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer

MIT License

893 stars 156 forks source link

Closed schmunk42 closed 6 years ago

schmunk42 commented 7 years ago

The only drawback is, that the parent method is copied, because of one line.

But performance looks even better and issues with local paths and duplicates copies do not occur so far.

schmunk42 commented 7 years ago

I need to check the tests, I wonder why the coverage is down, because it's actually the same code?!

schmunk42 commented 7 years ago

related #251

schmunk42 commented 7 years ago

@francoispluchino Sorry, I got it why coverage is down :) The used code is from composer.

Any advice how to proceed with this. I think a PR on composer side might take some time.

francoispluchino commented 7 years ago

@schmunk42 I'll take care of this PR this weekend.

schmunk42 commented 7 years ago

That would be awesome. I've also tested the PR in several of our projects without further problems, such as duplicates in cache.

We still might consider to mark this feature as experimental in 1.4.0.

francoispluchino commented 7 years ago

@schmunk42 I will take care of your PR start next week. Is it possible to fix the tests before?

francoispluchino commented 6 years ago

Thanks!