fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

Doesn't download recursive npm dependencies? #295

Closed kael-shipman closed 7 years ago

kael-shipman commented 7 years ago

Hey,

Not sure if maybe I'm just doing this wrong, but I built a small test project with the following details:

// composer.json
{
  "name": "test/test-project",
  "require": {
     "test/test-module": "~0.1"
  },
  "repositories": [
    {
      "type": "path",
      "url": "./dev-libs/test/test-module"
    }
  ]
}

Then in test-module:

// composer.json
{
  "name": "test/test-module",
  "require": {
     "npm-asset/jquery-ui-npm": "~1.12"
  }
}

Here, the required jquery-ui npm library further requires jquery, but when I run a totally fresh composer install, I get the following vendor hierarchy:

./vendor
  /test
    /test-module
  /npm-asset
    /jquery-ui-npm

Notice: no jquery under npm-asset.

Any suggestions are appreciated.

francoispluchino commented 7 years ago

Because the version 1.12.1 of jquery-ui-npm doesn't have any dependencies... ;-) See the package.json file.

francoispluchino commented 7 years ago

The jquery dependency is added in the dev-master see the commit jquery/jquery-ui@c1f96f11cc763cceb2dce87b1d42ce1ca1709d31.

kael-shipman commented 7 years ago

Ha! My bad. Sorry about that, and thanks for the quick reply! I think your plugin is totally going to save me from the woes of an overly complex package management scheme :).