search

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

git skip update does not work for some repos #315

Open schmunk42 opened 6 years ago

schmunk42 commented 6 years ago

ie. for several repos with a dash, but also async

Adding VCS repository npm-asset/csv-parse
(skip update) Adding VCS repository npm-asset/lodash
(skip update) Adding VCS repository npm-asset/esprima
(skip update) Adding VCS repository npm-asset/test262
Adding VCS repository npm-asset/async
(skip update) Adding VCS repository npm-asset/minimist
Adding VCS repository npm-asset/wordwrap
(skip update) Adding VCS repository bower-asset/jquery-growl
Adding VCS repository npm-asset/optimist

I think it's related to: https://github.com/fxpio/composer-asset-plugin/blob/dd559b0f69628277c868dcf3deeb17948e3e9b19/Repository/Vcs/GitDriver.php#L90

But I wasn't able to figure out the exact root cause.